Merge pull request rails#53247 from fatkodima/fix-cte-single-item-arrays

Fix CTE construction when passed arrays with single items

Author: kamipo

activerecord/lib/active_record/relation/query_methods.rb

@@ -1921,6 +1921,8 @@ def build_with_expression_from_value(value, nested = false)
           end
         when Arel::SelectManager then value
         when Array
+          return build_with_expression_from_value(value.first, false) if value.size == 1
+
           parts = value.map do |query|
             build_with_expression_from_value(query, true)
           end

activerecord/test/cases/relation/with_test.rb

@@ -74,6 +74,14 @@ def test_with_when_passing_arrays
         assert_equal (SPECIAL_POSTS + POSTS_WITH_TAGS + POSTS_WITH_COMMENTS).sort, relation.order(:id).pluck(:id)
       end
 
+      def test_with_when_passing_single_item_array
+        relation = Post
+          .with(posts_with_special_type_or_tags_or_comments: [Post.where(type: "SpecialPost")])
+          .from("posts_with_special_type_or_tags_or_comments AS posts")
+
+        assert_equal SPECIAL_POSTS.sort, relation.order(:id).pluck(:id)
+      end
+
       def test_with_recursive
         top_companies = Company.where(firm_id: nil).to_a
         child_companies = Company.where(firm_id: top_companies).to_a