Skip to content

Commit fc375d6

Browse files
committed
Address ApplicationTests::DBConsoleTest failures against asserion enabled Ruby
https://buildkite.com/rails/rails-nightly/builds/191#018dc3d1-902c-4b01-a82c-b662ebdbe567/1182-1188 Increasing timeout value from 10 to 100 for assert_output method addresses these failures. - Ruby built with debug options that takes more than 20 seconds and gets failed Here, the Ruby is built with these options: ``` cppflags="-DENABLE_PATH_CHECK=0 -DRUBY_DEBUG=1" optflags="-O3 -fno-inline" ``` ```ruby $ ruby -v ruby 3.4.0dev (2024-02-20T11:52:09Z master c22cb960cf) [x86_64-linux] $ time bin/test test/application/dbconsole_test.rb Run options: --seed 5685 F Failure: ApplicationTests::DBConsoleTest#test_use_value_defined_in_environment_file_in_database_yml [test/console_helpers.rb:19]: "sqlite>" expected, but got: . Expected "" to include "sqlite>". bin/test test/application/dbconsole_test.rb:21 F Failure: ApplicationTests::DBConsoleTest#test_respect_environment_option [test/console_helpers.rb:19]: "sqlite>" expected, but got: . Expected "" to include "sqlite>". bin/test test/application/dbconsole_test.rb:43 Finished in 10.105668s, 0.1979 runs/s, 0.3958 assertions/s. 2 runs, 4 assertions, 2 failures, 0 errors, 0 skips real 0m21.031s user 0m8.665s sys 0m2.286s $ ``` - Ruby built without debug options that finishes within second. ```ruby $ ruby -v ruby 3.4.0dev (2024-02-20T11:52:09Z master c22cb960cf) [x86_64-linux] $ time bin/test test/application/dbconsole_test.rb Run options: --seed 1479 .. Finished in 5.463076s, 0.3661 runs/s, 1.0983 assertions/s. 2 runs, 6 assertions, 0 failures, 0 errors, 0 skips real 0m9.942s user 0m2.288s sys 0m2.173s $ ```
1 parent 51ce412 commit fc375d6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

railties/test/application/dbconsole_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def test_use_value_defined_in_environment_file_in_database_yml
3535

3636
primary, replica = PTY.open
3737
spawn_dbconsole(replica)
38-
assert_output("sqlite>", primary)
38+
assert_output("sqlite>", primary, 100)
3939
ensure
4040
primary.puts ".exit"
4141
end
@@ -58,7 +58,7 @@ def test_respect_environment_option
5858

5959
primary, replica = PTY.open
6060
spawn_dbconsole(replica, "-e production")
61-
assert_output("sqlite>", primary)
61+
assert_output("sqlite>", primary, 100)
6262

6363
primary.puts "pragma database_list;"
6464
assert_output("production.sqlite3", primary)

0 commit comments

Comments
 (0)