Merge pull request rails#50670 from byroot/active-support-after-fork-check

Get rid of `ForkTracker.check!`

Author: byroot

activerecord/lib/active_record/connection_adapters/abstract/connection_handler.rb

@@ -55,9 +55,6 @@ module ConnectionAdapters
     # about the model. The model needs to pass a connection specification name to the handler,
     # in order to look up the correct connection pool.
     class ConnectionHandler
-      FINALIZER = lambda { |_| ActiveSupport::ForkTracker.check! }
-      private_constant :FINALIZER
-
       class StringConnectionName # :nodoc:
         attr_reader :name
 
@@ -77,9 +74,6 @@ def current_preventing_writes
       def initialize
         # These caches are keyed by pool_config.connection_name (PoolConfig#connection_name).
         @connection_name_to_pool_manager = Concurrent::Map.new(initial_capacity: 2)
-
-        # Backup finalizer: if the forked child skipped Kernel#fork the early discard has not occurred
-        ObjectSpace.define_finalizer self, FINALIZER
       end
 
       def prevent_writes # :nodoc:

activerecord/lib/active_record/connection_adapters/pool_config.rb

@@ -50,8 +50,6 @@ def connection_name
       end
 
       def disconnect!(automatic_reconnect: false)
-        ActiveSupport::ForkTracker.check!
-
         return unless @pool
 
         synchronize do
@@ -65,8 +63,6 @@ def disconnect!(automatic_reconnect: false)
       end
 
       def pool
-        ActiveSupport::ForkTracker.check!
-
         @pool || synchronize { @pool ||= ConnectionAdapters::ConnectionPool.new(self) }
       end
 

activesupport/lib/active_support/fork_tracker.rb

@@ -24,14 +24,6 @@ def after_fork_callback
         end
       end
 
-      if Process.respond_to?(:_fork) # Ruby 3.1+
-        def check!
-          # We trust the `_fork` callback
-        end
-      else
-        alias_method :check!, :after_fork_callback
-      end
-
       def hook!
         ::Process.singleton_class.prepend(CoreExt)
       end

activesupport/test/fork_tracker_test.rb

@@ -152,39 +152,6 @@ def test_kernel_fork_without_block
     ActiveSupport::ForkTracker.unregister(handler)
   end
 
-  def test_check
-    count = 0
-    handler = ActiveSupport::ForkTracker.after_fork { count += 1 }
-
-    assert_no_difference -> { count } do
-      3.times { ActiveSupport::ForkTracker.check! }
-    end
-
-    if Process.respond_to?(:_fork)
-      Process.stub(:pid, Process.pid + 1) do
-        assert_no_difference -> { count } do
-          3.times { ActiveSupport::ForkTracker.check! }
-        end
-
-        assert_no_difference -> { count } do
-          3.times { ActiveSupport::ForkTracker.check! }
-        end
-      end
-    else
-      Process.stub(:pid, Process.pid + 1) do
-        assert_difference -> { count }, +1 do
-          3.times { ActiveSupport::ForkTracker.check! }
-        end
-      end
-
-      assert_difference -> { count }, +1 do
-        3.times { ActiveSupport::ForkTracker.check! }
-      end
-    end
-  ensure
-    ActiveSupport::ForkTracker.unregister(handler)
-  end
-
   def test_basic_object_with_kernel_fork
     read, write = IO.pipe
     called = false