Skip to content

Commit 8caa04d

Browse files
committed
remove passlib-specific hack and update TODO
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
1 parent 4e51293 commit 8caa04d

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

TODO.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,7 @@
3636

3737
- If a user is deleted while logged in, the API returns a 500 (Internal Server
3838
Error).
39-
- `passlib`, used to hash passwords, is pretty much abandoned, we should
40-
probably just use `bcrypt` directly. This would allow us to upgrade to the
41-
latest `bcrypt` package too. [NOTE: There is also a fork `libpass` that fixes
42-
this and continues the project.]
39+
4340

4441
## Auth
4542

app/commands/user.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
from __future__ import annotations
44

5-
import logging
65
from asyncio import run as aiorun
76
from typing import TYPE_CHECKING, Optional
87

@@ -105,8 +104,6 @@ def create(
105104
Values are either taken from the command line options, or interactively for
106105
any that are missing.
107106
"""
108-
# disable passlib logging, due to issues with latest bcrypt.
109-
logging.getLogger("passlib").setLevel(logging.ERROR)
110107

111108
async def _create_user(user_data: dict[str, str | RoleType]) -> None:
112109
"""Async function to create a new user."""

0 commit comments

Comments
 (0)