Merge pull request #75 from seb-oss/feature/update-talkback

[MCORE-185] Update talkback for the input component

Author: lisandra-santos

components/src/main/kotlin/se/seb/gds/atoms/input/BasicInput.kt

@@ -15,7 +15,6 @@ import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.text.input.InputTransformation
 import androidx.compose.foundation.text.input.TextFieldLineLimits
 import androidx.compose.foundation.text.input.TextFieldState
-import androidx.compose.foundation.text.input.delete
 import androidx.compose.foundation.text.input.then
 import androidx.compose.material3.Icon
 import androidx.compose.material3.Text
@@ -254,6 +253,21 @@ internal fun getAccessibilityDescription(
         descriptionBuilder.append(stringResource(id = R.string.text_field_is_editing))
     }
 
+    // Announce character count if the text field is valid. If not valid, the error message will
+    // include the character limit information, so it would be redundant to announce it here as well.
+    val isCharacterLimitValid =
+        inputState.characterLimit != null && state.text.length <= inputState.characterLimit.maxCharacters
+    if (textFieldIsFocused && isCharacterLimitValid) {
+        descriptionBuilder.append(", ")
+        descriptionBuilder.append(
+            stringResource(
+                id = R.string.text_field_characters_written,
+                state.text.length,
+                inputState.characterLimit.maxCharacters,
+            ),
+        )
+    }
+
     return descriptionBuilder.toString().replace(" ,", ",").trim()
 }
 

components/src/main/kotlin/se/seb/gds/atoms/input/GdsInputContained.kt

@@ -243,7 +243,7 @@ fun InputContainedCore(
         LocalTextSelectionColors provides style.basicInputStyle.textSelectionColors,
     ) {
         BasicTextField(
-            modifier = Modifier
+            modifier = modifier
                 .bringIntoViewRequester(bringIntoViewRequester)
                 .focusRequester(focusRequester)
                 .clearAndSetSemantics {

components/src/main/res/values/strings.xml

@@ -2,7 +2,7 @@
 <resources>
     <string name="common_action_close">Stäng</string>
     <string name="text_field">Textfält</string>
-    <string name="text_field_error_in_field">Det finns ett fel i Textfält.</string>
+    <string name="text_field_error_in_field">Det finns ett fel i textfältet.</string>
     <string name="text_field_character_limit_error">Du kan skriva högst %d tecken.</string>
     <string name="text_field_edit">ändra</string>
     <string name="text_field_is_editing">ändrar</string>