Skip to content

Commit 9286cf2

Browse files
committed
Update review comments
1 parent e745ee6 commit 9286cf2

9 files changed

+46
-13
lines changed

components/src/screenshotTest/kotlin/se/seb/gds/atoms/CircularProgressIndicatorScreenshotTests.kt

Lines changed: 28 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
package se.seb.gds.atoms
22

3-
import androidx.compose.foundation.layout.Arrangement
43
import androidx.compose.foundation.layout.Column
54
import androidx.compose.foundation.layout.padding
65
import androidx.compose.runtime.Composable
7-
import androidx.compose.ui.Alignment
86
import androidx.compose.ui.Modifier
97
import androidx.compose.ui.unit.dp
108
import com.android.tools.screenshot.PreviewTest
@@ -17,17 +15,40 @@ import se.seb.gds.theme.GdsTheme
1715
@PreviewTest
1816
@GdsUiTestsPreview
1917
@Composable
20-
private fun GdsCircularProgressIndicatorScreenshot() {
18+
private fun GdsCircularProgressIndicatorDefaultScreenshot() {
2119
GdsTheme {
2220
Column(
2321
modifier = Modifier.padding(GdsTheme.dimensions.spacing.SpaceM),
24-
horizontalAlignment = Alignment.CenterHorizontally,
25-
verticalArrangement = Arrangement.spacedBy(8.dp),
2622
) {
27-
// Default circular progress indicator
2823
GdsCircularProgressIndicator()
24+
}
25+
}
26+
}
2927

30-
// Circular progress indicator with custom size
28+
@PreviewTest
29+
@GdsUiTestsPreview
30+
@Composable
31+
private fun GdsCircularProgressIndicatorWithCustomColorScreenshot() {
32+
GdsTheme {
33+
Column(
34+
modifier = Modifier.padding(GdsTheme.dimensions.spacing.SpaceM),
35+
) {
36+
GdsCircularProgressIndicator(
37+
color = GdsTheme.colors.Border.Subtle01,
38+
trackColor = GdsTheme.colors.Border.Strong,
39+
)
40+
}
41+
}
42+
}
43+
44+
@PreviewTest
45+
@GdsUiTestsPreview
46+
@Composable
47+
private fun GdsCircularProgressIndicatorWithCustomSize60DpScreenshot() {
48+
GdsTheme {
49+
Column(
50+
modifier = Modifier.padding(GdsTheme.dimensions.spacing.SpaceM),
51+
) {
3152
GdsCircularProgressIndicator(size = 60.dp)
3253
}
3354
}
Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading

components/src/screenshotTestDebug/reference/se/seb/gds/atoms/CircularProgressIndicatorScreenshotTestsKt/GdsCircularProgressIndicatorScreenshot_Dark_15088e0a_0.png

Lines changed: 0 additions & 3 deletions
This file was deleted.

components/src/screenshotTestDebug/reference/se/seb/gds/atoms/CircularProgressIndicatorScreenshotTestsKt/GdsCircularProgressIndicatorScreenshot_Light_a39638cd_0.png

Lines changed: 0 additions & 3 deletions
This file was deleted.
Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading

0 commit comments

Comments
 (0)