Merge branch '13.0'

* 13.0:
  Add tests

Author: sebastianbergmann

tests/_files/mock-object/InterfaceWithMethodNamedMethod.php

@@ -0,0 +1,15 @@
+<?php declare(strict_types=1);
+/*
+ * This file is part of PHPUnit.
+ *
+ * (c) Sebastian Bergmann <sebastian@phpunit.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace PHPUnit\TestFixture\MockObject;
+
+interface InterfaceWithMethodNamedMethod
+{
+    public function method(): bool;
+}

tests/unit/Framework/MockObject/Creation/CreateMockTest.php

@@ -14,13 +14,17 @@
 use PHPUnit\Framework\Attributes\TestDox;
 use PHPUnit\Framework\MockObject\Generator\ClassIsEnumerationException;
 use PHPUnit\Framework\MockObject\Generator\ClassIsFinalException;
+use PHPUnit\Framework\MockObject\Generator\Generator;
+use PHPUnit\Framework\MockObject\Generator\InvalidMethodNameException;
+use PHPUnit\Framework\MockObject\Generator\MethodNamedMethodException;
 use PHPUnit\Framework\MockObject\Generator\UnknownTypeException;
 use PHPUnit\Framework\TestCase;
 use PHPUnit\TestFixture\MockObject\AnInterface;
 use PHPUnit\TestFixture\MockObject\Enumeration;
 use PHPUnit\TestFixture\MockObject\ExtendableClass;
 use PHPUnit\TestFixture\MockObject\ExtendableReadonlyClass;
 use PHPUnit\TestFixture\MockObject\FinalClass;
+use PHPUnit\TestFixture\MockObject\InterfaceWithMethodNamedMethod;
 
 #[Group('test-doubles')]
 #[Group('test-doubles/creation')]
@@ -83,4 +87,24 @@ public function testCannotCreateMockObjectForUnknownType(): void
 
         $this->createMock('this\does\not\exist');
     }
+
+    public function testCannotCreateMockObjectWithInvalidMethodName(): void
+    {
+        $this->expectException(InvalidMethodNameException::class);
+        $this->expectExceptionMessage('Cannot double method with invalid name "0"');
+
+        (new Generator)->testDouble(
+            AnInterface::class,
+            true,
+            ['0'],
+        );
+    }
+
+    public function testCannotCreateMockObjectForInterfaceWithMethodNamedMethod(): void
+    {
+        $this->expectException(MethodNamedMethodException::class);
+        $this->expectExceptionMessage('Doubling interfaces (or classes) that have a method named "method" is not supported.');
+
+        $this->createMock(InterfaceWithMethodNamedMethod::class);
+    }
 }

tests/unit/Framework/MockObject/MockObjectTest.php

@@ -778,6 +778,40 @@ public function testSealedPartialMockObjectOnlyAffectsMockedMethods(): void
         $this->assertFalse($double->doSomething());
     }
 
+    public function testMethodNameMustBeConfiguredBeforeMethodParametersCanBeConfigured(): void
+    {
+        $double = $this->createMock(InterfaceWithReturnTypeDeclaration::class);
+
+        try {
+            $double->expects($this->once())->with(1);
+        } catch (MethodNameNotConfiguredException $e) {
+            $this->assertSame('Method name is not configured', $e->getMessage());
+
+            return;
+        } finally {
+            $this->resetMockObjects();
+        }
+
+        $this->fail();
+    }
+
+    public function testMethodParametersCanOnlyBeConfiguredOnce(): void
+    {
+        $double = $this->createMock(InterfaceWithReturnTypeDeclaration::class);
+
+        try {
+            $double->expects($this->once())->method('doSomethingElse')->with(1)->with(2);
+        } catch (MethodParametersAlreadyConfiguredException $e) {
+            $this->assertSame('Method parameters already configured', $e->getMessage());
+
+            return;
+        } finally {
+            $this->resetMockObjects();
+        }
+
+        $this->fail();
+    }
+
     /**
      * @param class-string $type
      */

tests/unit/Framework/MockObject/TestDoubleTestCase.php

@@ -12,12 +12,14 @@
 use Exception;
 use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\TestDox;
+use PHPUnit\Framework\MockObject\Generator\MethodNamedMethodException;
 use PHPUnit\Framework\MockObject\Runtime\PropertyHook;
 use PHPUnit\Framework\TestCase;
 use PHPUnit\TestFixture\MockObject\ExtendableClassCallingMethodInDestructor;
 use PHPUnit\TestFixture\MockObject\ExtendableClassWithCloneMethod;
 use PHPUnit\TestFixture\MockObject\ExtendableClassWithPropertyWithGetHook;
 use PHPUnit\TestFixture\MockObject\ExtendableReadonlyClassWithCloneMethod;
+use PHPUnit\TestFixture\MockObject\InterfaceWithMethodNamedMethod;
 use PHPUnit\TestFixture\MockObject\InterfaceWithMethodThatHasDefaultParameterValues;
 use PHPUnit\TestFixture\MockObject\InterfaceWithNeverReturningMethod;
 use PHPUnit\TestFixture\MockObject\InterfaceWithPropertyWithGetHook;
@@ -344,6 +346,15 @@ public function testClonedSealedTestDoubleRemainsSealed(): void
         $clone->method('doSomethingElse');
     }
 
+    #[TestDox('Cannot create test double for an interface that has a method named "method"')]
+    public function testCannotCreateTestDoubleForInterfaceWithMethodNamedMethod(): void
+    {
+        $this->expectException(MethodNamedMethodException::class);
+        $this->expectExceptionMessage('Doubling interfaces (or classes) that have a method named "method" is not supported.');
+
+        $this->createTestDouble(InterfaceWithMethodNamedMethod::class);
+    }
+
     /**
      * @template RealInstanceType of object
      *