Rename

Author: sebastianbergmann

.psalm/baseline.xml

@@ -1014,7 +1014,7 @@
       <code>new StandardTestSuiteLoader</code>
       <code>new XdebugFilterScriptGenerator</code>
     </DeprecatedClass>
-    <DeprecatedMethod occurrences="9">
+    <DeprecatedMethod occurrences="10">
       <code>addListener</code>
       <code>addListener</code>
       <code>addListener</code>
@@ -1023,6 +1023,7 @@
       <code>addListener</code>
       <code>addListener</code>
       <code>addListener</code>
+      <code>createLegacyInstance</code>
       <code>flushListeners</code>
     </DeprecatedMethod>
     <DocblockTypeContradiction occurrences="2">

src/Runner/Extension/ExtensionHandler.php

@@ -23,9 +23,9 @@
  */
 final class ExtensionHandler
 {
-    public function createHookInstance(Extension $extension): Hook
+    public function createInstance(Extension $extension): Hook
     {
-        $object = $this->createInstance($extension);
+        $object = $this->doCreateInstance($extension);
 
         if (!$object instanceof Hook) {
             throw new Exception(
@@ -39,9 +39,12 @@ public function createHookInstance(Extension $extension): Hook
         return $object;
     }
 
-    public function createTestListenerInstance(Extension $extension): TestListener
+    /**
+     * @deprecated
+     */
+    public function createLegacyInstance(Extension $extension): TestListener
     {
-        $object = $this->createInstance($extension);
+        $object = $this->doCreateInstance($extension);
 
         if (!$object instanceof TestListener) {
             throw new Exception(
@@ -55,7 +58,7 @@ public function createTestListenerInstance(Extension $extension): TestListener
         return $object;
     }
 
-    private function createInstance(Extension $extension): object
+    private function doCreateInstance(Extension $extension): object
     {
         $this->ensureClassExists($extension);
 

src/TextUI/TestRunner.php

@@ -1021,11 +1021,11 @@ private function handleConfiguration(array &$arguments): void
             $extensionHandler = new ExtensionHandler;
 
             foreach ($arguments['configurationObject']->extensions() as $extension) {
-                $this->addExtension($extensionHandler->createHookInstance($extension));
+                $this->addExtension($extensionHandler->createInstance($extension));
             }
 
             foreach ($arguments['configurationObject']->listeners() as $listener) {
-                $arguments['listeners'][] = $extensionHandler->createTestListenerInstance($listener);
+                $arguments['listeners'][] = $extensionHandler->createLegacyInstance($listener);
             }
 
             unset($extensionHandler);
@@ -1082,7 +1082,7 @@ private function handleConfiguration(array &$arguments): void
         $extensionHandler = new ExtensionHandler;
 
         foreach ($arguments['extensions'] as $extension) {
-            $this->addExtension($extensionHandler->createHookInstance($extension));
+            $this->addExtension($extensionHandler->createInstance($extension));
         }
 
         unset($extensionHandler);