Fix: Evaluate condition before looping

Author: localheinz

src/Framework/TestSuite.php

@@ -610,56 +610,56 @@ public function run(TestResult $result = null): TestResult
 
         $test = null;
 
-        try {
-            foreach ($hookMethods['beforeClass'] as $beforeClassMethod) {
-                if ($this->testCase &&
-                    class_exists($this->name, false) &&
-                    method_exists($this->name, $beforeClassMethod)) {
-                    if ($missingRequirements = TestUtil::getMissingRequirements($this->name, $beforeClassMethod)) {
-                        $this->markTestSuiteSkipped(implode(PHP_EOL, $missingRequirements));
-                    }
+        if ($this->testCase && class_exists($this->name, false)) {
+            try {
+                foreach ($hookMethods['beforeClass'] as $beforeClassMethod) {
+                    if (method_exists($this->name, $beforeClassMethod)) {
+                        if ($missingRequirements = TestUtil::getMissingRequirements($this->name, $beforeClassMethod)) {
+                            $this->markTestSuiteSkipped(implode(PHP_EOL, $missingRequirements));
+                        }
 
-                    call_user_func([$this->name, $beforeClassMethod]);
+                        call_user_func([$this->name, $beforeClassMethod]);
+                    }
+                }
+            } catch (SkippedTestSuiteError $error) {
+                foreach ($this->tests() as $test) {
+                    $result->startTest($test);
+                    $result->addFailure($test, $error, 0);
+                    $result->endTest($test, 0);
                 }
-            }
-        } catch (SkippedTestSuiteError $error) {
-            foreach ($this->tests() as $test) {
-                $result->startTest($test);
-                $result->addFailure($test, $error, 0);
-                $result->endTest($test, 0);
-            }
 
-            $result->endTestSuite($this);
+                $result->endTestSuite($this);
 
-            return $result;
-        } catch (Throwable $t) {
-            $errorAdded = false;
+                return $result;
+            } catch (Throwable $t) {
+                $errorAdded = false;
 
-            foreach ($this->tests() as $test) {
-                if ($result->shouldStop()) {
-                    break;
-                }
+                foreach ($this->tests() as $test) {
+                    if ($result->shouldStop()) {
+                        break;
+                    }
 
-                $result->startTest($test);
+                    $result->startTest($test);
 
-                if (!$errorAdded) {
-                    $result->addError($test, $t, 0);
+                    if (!$errorAdded) {
+                        $result->addError($test, $t, 0);
 
-                    $errorAdded = true;
-                } else {
-                    $result->addFailure(
-                        $test,
-                        new SkippedTestError('Test skipped because of an error in hook method'),
-                        0
-                    );
-                }
+                        $errorAdded = true;
+                    } else {
+                        $result->addFailure(
+                            $test,
+                            new SkippedTestError('Test skipped because of an error in hook method'),
+                            0
+                        );
+                    }
 
-                $result->endTest($test, 0);
-            }
+                    $result->endTest($test, 0);
+                }
 
-            $result->endTestSuite($this);
+                $result->endTestSuite($this);
 
-            return $result;
+                return $result;
+            }
         }
 
         foreach ($this as $test) {
@@ -677,22 +677,22 @@ class_exists($this->name, false) &&
             $test->run($result);
         }
 
-        foreach ($hookMethods['afterClass'] as $afterClassMethod) {
-            if ($this->testCase &&
-                class_exists($this->name, false) &&
-                method_exists($this->name, $afterClassMethod)) {
-                try {
-                    call_user_func([$this->name, $afterClassMethod]);
-                } catch (Throwable $t) {
-                    $message = "Exception in {$this->name}::{$afterClassMethod}" . PHP_EOL . $t->getMessage();
-                    $error   = new SyntheticError($message, 0, $t->getFile(), $t->getLine(), $t->getTrace());
+        if ($this->testCase && class_exists($this->name, false)) {
+            foreach ($hookMethods['afterClass'] as $afterClassMethod) {
+                if (method_exists($this->name, $afterClassMethod)) {
+                    try {
+                        call_user_func([$this->name, $afterClassMethod]);
+                    } catch (Throwable $t) {
+                        $message = "Exception in {$this->name}::{$afterClassMethod}" . PHP_EOL . $t->getMessage();
+                        $error   = new SyntheticError($message, 0, $t->getFile(), $t->getLine(), $t->getTrace());
 
-                    $placeholderTest = clone $test;
-                    $placeholderTest->setName($afterClassMethod);
+                        $placeholderTest = clone $test;
+                        $placeholderTest->setName($afterClassMethod);
 
-                    $result->startTest($placeholderTest);
-                    $result->addFailure($placeholderTest, $error, 0);
-                    $result->endTest($placeholderTest, 0);
+                        $result->startTest($placeholderTest);
+                        $result->addFailure($placeholderTest, $error, 0);
+                        $result->endTest($placeholderTest, 0);
+                    }
                 }
             }
         }