Eliminate risky truthy/falsy comparison

sebastianbergmann · sebastianbergmann · commit 2289943374bb · 2024-05-11T07:23:16.000+02:00
diff --git a/src/Runner/PhptTestCase.php b/src/Runner/PhptTestCase.php
@@ -314,7 +314,7 @@ private function parseEnvSection(string $content): array
         foreach (explode("\n", trim($content)) as $e) {
             $e = explode('=', trim($e), 2);
 
-            if (!empty($e[0]) && isset($e[1])) {
+            if ($e[0] !== '' && isset($e[1])) {
                 $env[$e[0]] = $e[1];
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,7 @@ private function parseEnvSection(string $content): array`
`314`	`314`	`foreach (explode("\n", trim($content)) as $e) {`
`315`	`315`	`$e = explode('=', trim($e), 2);`
`316`	`316`
`317`		`- if (!empty($e[0]) && isset($e[1])) {`
	`317`	`+ if ($e[0] !== '' && isset($e[1])) {`
`318`	`318`	`$env[$e[0]] = $e[1];`
`319`	`319`	`}`
`320`	`320`	`}`