Test baseline with all six types (E_DEPRECATED, E_NOTICE, E_WARNING, E_USER_DEPRECATED, E_USER_NOTICE, E_USER_WARNING) of issues that can be ignored

Author: sebastianbergmann

.php-cs-fixer.dist.php

@@ -16,6 +16,8 @@
     ->in(__DIR__ . '/tests/unit')
     // DeprecatedPhpFeatureTest.php must not use declare(strict_types=1);
     ->notName('DeprecatedPhpFeatureTest.php')
+    // UseBaselineTest.php must not use declare(strict_types=1);
+    ->notName('UseBaselineTest.php')
     // Issue5795Test.php contains required whitespace that would be cleaned up
     ->notName('Issue5795Test.php')
     ->notName('*.phpt');

tests/end-to-end/_files/baseline/use-baseline/baseline.xml

@@ -1,8 +1,23 @@
 <?xml version="1.0"?>
 <files version="1">
-    <file path="tests/Test.php">
-        <line number="20" hash="a1022fb62c4705938dd2c6df5ff35b2621f9e97d">
-            <issue><![CDATA[deprecation]]></issue>
-        </line>
-    </file>
+ <file path="tests/UseBaselineTest.php">
+  <line number="23" hash="dba225b56a963ec1cb91eff6711e51d9e3df6c6e">
+   <issue><![CDATA[strlen(): Passing null to parameter #1 ($string) of type string is deprecated]]></issue>
+  </line>
+  <line number="29" hash="b8af300020a6744a3774f463a41339c21bef5648">
+   <issue><![CDATA[Only variables should be assigned by reference]]></issue>
+  </line>
+  <line number="31" hash="1144713f7825a9ca87b378ce41789cf994e627e6">
+   <issue><![CDATA[Undefined variable $b]]></issue>
+  </line>
+  <line number="33" hash="a1022fb62c4705938dd2c6df5ff35b2621f9e97d">
+   <issue><![CDATA[deprecation]]></issue>
+  </line>
+  <line number="34" hash="fff8be75c2fbcbc4d395247e58fbbe6541189cf0">
+   <issue><![CDATA[notice]]></issue>
+  </line>
+  <line number="35" hash="a5b91c0a182bedb089007e5bc0d0f462637bc904">
+   <issue><![CDATA[warning]]></issue>
+  </line>
+ </file>
 </files>

tests/end-to-end/_files/baseline/use-baseline/tests/Test.php renamed to tests/end-to-end/_files/baseline/use-baseline/tests/UseBaselineTest.php

@@ -1,4 +1,4 @@
-<?php declare(strict_types=1);
+<?php
 /*
  * This file is part of PHPUnit.
  *
@@ -10,14 +10,29 @@
 namespace PHPUnit\TestFixture\Baseline;
 
 use const E_USER_DEPRECATED;
+use const E_USER_NOTICE;
+use const E_USER_WARNING;
+use function strlen;
 use function trigger_error;
 use PHPUnit\Framework\TestCase;
 
-final class Test extends TestCase
+final class UseBaselineTest extends TestCase
 {
     public function testOne(): void
     {
+        strlen(null);
+
+        $f = static function (): void
+        {
+        };
+
+        $a  = &$f();
+
+        $a = $b;
+
         trigger_error('deprecation', E_USER_DEPRECATED);
+        trigger_error('notice', E_USER_NOTICE);
+        trigger_error('warning', E_USER_WARNING);
 
         $this->assertTrue(true);
     }

tests/end-to-end/baseline/ignore-baseline.phpt

@@ -7,6 +7,8 @@ $_SERVER['argv'][] = '--configuration';
 $_SERVER['argv'][] = __DIR__ . '/../_files/baseline/use-baseline/phpunit.xml';
 $_SERVER['argv'][] = '--ignore-baseline';
 $_SERVER['argv'][] = '--display-deprecations';
+$_SERVER['argv'][] = '--display-notices';
+$_SERVER['argv'][] = '--display-warnings';
 
 require_once __DIR__ . '/../../bootstrap.php';
 
@@ -17,19 +19,79 @@ PHPUnit %s by Sebastian Bergmann and contributors.
 Runtime: %s
 Configuration: %s
 
-D                                                                   1 / 1 (100%)
+W                                                                   1 / 1 (100%)
 
 Time: %s, Memory: %s
 
+1 test triggered 1 PHP warning:
+
+1) %sUseBaselineTest.php:31
+Undefined variable $b
+
+Triggered by:
+
+* PHPUnit\TestFixture\Baseline\UseBaselineTest::testOne
+  %sUseBaselineTest.php:21
+
+--
+
+1 test triggered 1 warning:
+
+1) %sUseBaselineTest.php:35
+warning
+
+Triggered by:
+
+* PHPUnit\TestFixture\Baseline\UseBaselineTest::testOne
+  %sUseBaselineTest.php:21
+
+--
+
+1 test triggered 1 PHP notice:
+
+1) %sUseBaselineTest.php:29
+Only variables should be assigned by reference
+
+Triggered by:
+
+* PHPUnit\TestFixture\Baseline\UseBaselineTest::testOne
+  %sUseBaselineTest.php:21
+
+--
+
+1 test triggered 1 notice:
+
+1) %sUseBaselineTest.php:34
+notice
+
+Triggered by:
+
+* PHPUnit\TestFixture\Baseline\UseBaselineTest::testOne
+  %sUseBaselineTest.php:21
+
+--
+
+1 test triggered 1 PHP deprecation:
+
+1) %sUseBaselineTest.php:23
+strlen(): Passing null to parameter #1 ($string) of type string is deprecated
+
+Triggered by:
+
+* PHPUnit\TestFixture\Baseline\UseBaselineTest::testOne
+  %sUseBaselineTest.php:21
+
+--
+
 1 test triggered 1 deprecation:
 
-1) %sTest.php:%d
+1) %sUseBaselineTest.php:33
 deprecation
 
 Triggered by:
 
-* PHPUnit\TestFixture\Baseline\Test::testOne
-  %sTest.php:%d
+* PHPUnit\TestFixture\Baseline\UseBaselineTest::testOne
+  %sUseBaselineTest.php:21
 
 OK, but there were issues!
-Tests: 1, Assertions: 1, Deprecations: 1.
+Tests: 1, Assertions: 1, Warnings: 2, Deprecations: 2, Notices: 2.

tests/end-to-end/baseline/use-baseline.phpt

@@ -21,4 +21,4 @@ Time: %s, Memory: %s
 
 OK (1 test, 1 assertion)
 
-1 issue was ignored by baseline.
+6 issues were ignored by baseline.