Use consistent variable name

sebastianbergmann · sebastianbergmann · commit 2ad0441518ff · 2024-12-11T10:18:22.000+01:00
diff --git a/tests/unit/Framework/MockObject/Creation/CreateConfiguredMockTest.php b/tests/unit/Framework/MockObject/Creation/CreateConfiguredMockTest.php
@@ -24,15 +24,15 @@ final class CreateConfiguredMockTest extends TestCase
 {
     public function testCreatesMockObjectForInterfaceOrExtendableClassWithReturnValueConfigurationForMultipleMethods(): void
     {
-        $stub = $this->createConfiguredMock(
+        $double = $this->createConfiguredMock(
             InterfaceWithReturnTypeDeclaration::class,
             [
                 'doSomething'     => true,
                 'doSomethingElse' => 1,
             ],
         );
 
-        $this->assertTrue($stub->doSomething());
-        $this->assertSame(1, $stub->doSomethingElse(0));
+        $this->assertTrue($double->doSomething());
+        $this->assertSame(1, $double->doSomethingElse(0));
     }
 }
diff --git a/tests/unit/Framework/MockObject/Creation/CreateConfiguredStubTest.php b/tests/unit/Framework/MockObject/Creation/CreateConfiguredStubTest.php
@@ -24,15 +24,15 @@ final class CreateConfiguredStubTest extends TestCase
 {
     public function testCreatesTestStubForInterfaceOrExtendableClassWithReturnValueConfigurationForMultipleMethods(): void
     {
-        $stub = $this->createConfiguredStub(
+        $double = $this->createConfiguredStub(
             InterfaceWithReturnTypeDeclaration::class,
             [
                 'doSomething'     => true,
                 'doSomethingElse' => 1,
             ],
         );
 
-        $this->assertTrue($stub->doSomething());
-        $this->assertSame(1, $stub->doSomethingElse(0));
+        $this->assertTrue($double->doSomething());
+        $this->assertSame(1, $double->doSomethingElse(0));
     }
 }
diff --git a/tests/unit/Framework/MockObject/Creation/CreatePartialMockTest.php b/tests/unit/Framework/MockObject/Creation/CreatePartialMockTest.php
@@ -26,11 +26,11 @@ final class CreatePartialMockTest extends TestCase
 {
     public function testCreatesPartialMockObjectForExtendableClass(): void
     {
-        $mock = $this->createPartialMock(ExtendableClass::class, ['doSomethingElse']);
+        $double = $this->createPartialMock(ExtendableClass::class, ['doSomethingElse']);
 
-        $mock->expects($this->once())->method('doSomethingElse')->willReturn(true);
+        $double->expects($this->once())->method('doSomethingElse')->willReturn(true);
 
-        $this->assertTrue($mock->doSomething());
+        $this->assertTrue($double->doSomething());
     }
 
     public function testCannotCreatePartialMockObjectForExtendableClassWithDuplicateMethods(): void
@@ -43,10 +43,10 @@ public function testCannotCreatePartialMockObjectForExtendableClassWithDuplicate
 
     public function testMethodOfPartialMockThatIsNotConfigurableCannotBeConfigured(): void
     {
-        $mock = $this->createPartialMock(ExtendableClass::class, ['doSomethingElse']);
+        $double = $this->createPartialMock(ExtendableClass::class, ['doSomethingElse']);
 
         try {
-            $mock->expects($this->once())->method('doSomething')->willReturn(true);
+            $double->expects($this->once())->method('doSomething')->willReturn(true);
         } catch (MethodCannotBeConfiguredException $e) {
             $this->assertSame('Trying to configure method "doSomething" which cannot be configured because it does not exist, has not been specified, is final, or is static', $e->getMessage());
 
diff --git a/tests/unit/Framework/MockObject/Creation/CreateTestProxyTest.php b/tests/unit/Framework/MockObject/Creation/CreateTestProxyTest.php
@@ -25,14 +25,14 @@ final class CreateTestProxyTest extends TestCase
 {
     public function testCreatesTestProxyForExtendableClass(): void
     {
-        $proxy = $this->createTestProxy(TestProxyFixture::class);
+        $double = $this->createTestProxy(TestProxyFixture::class);
 
-        $proxy->expects($this->once())
+        $double->expects($this->once())
             ->method('returnString');
 
-        assert($proxy instanceof MockObject);
-        assert($proxy instanceof TestProxyFixture);
+        assert($double instanceof MockObject);
+        assert($double instanceof TestProxyFixture);
 
-        $this->assertSame('result', $proxy->returnString());
+        $this->assertSame('result', $double->returnString());
     }
 }
diff --git a/tests/unit/Framework/MockObject/Creation/GetMockForAbstractClassTest.php b/tests/unit/Framework/MockObject/Creation/GetMockForAbstractClassTest.php
@@ -28,11 +28,11 @@ final class GetMockForAbstractClassTest extends TestCase
 {
     public function testCreatesMockObjectForAbstractClassAndAllowsConfigurationOfAbstractMethods(): void
     {
-        $mock = $this->getMockForAbstractClass(AbstractClass::class);
+        $double = $this->getMockForAbstractClass(AbstractClass::class);
 
-        $mock->expects($this->once())->method('doSomethingElse')->willReturn(true);
+        $double->expects($this->once())->method('doSomethingElse')->willReturn(true);
 
-        $this->assertTrue($mock->doSomething());
+        $this->assertTrue($double->doSomething());
     }
 
     public function testCannotCreateMockObjectForAbstractClassThatDoesNotExist(): void
@@ -45,10 +45,10 @@ public function testCannotCreateMockObjectForAbstractClassThatDoesNotExist(): vo
 
     public function testCreatesMockObjectForAbstractClassAndDoesNotAllowConfigurationOfConcreteMethods(): void
     {
-        $mock = $this->getMockForAbstractClass(AbstractClass::class);
+        $double = $this->getMockForAbstractClass(AbstractClass::class);
 
         try {
-            $mock->expects($this->once())->method('doSomething');
+            $double->expects($this->once())->method('doSomething');
         } catch (MethodCannotBeConfiguredException $e) {
             $this->assertSame('Trying to configure method "doSomething" which cannot be configured because it does not exist, has not been specified, is final, or is static', $e->getMessage());
 
diff --git a/tests/unit/Framework/MockObject/Creation/GetMockForTraitTest.php b/tests/unit/Framework/MockObject/Creation/GetMockForTraitTest.php
@@ -25,11 +25,11 @@ final class GetMockForTraitTest extends TestCase
 {
     public function testCreatesMockObjectForTraitAndAllowsConfigurationOfAbstractMethods(): void
     {
-        $mock = $this->getMockForTrait(TraitWithConcreteAndAbstractMethod::class);
+        $double = $this->getMockForTrait(TraitWithConcreteAndAbstractMethod::class);
 
-        $mock->method('abstractMethod')->willReturn(true);
+        $double->method('abstractMethod')->willReturn(true);
 
-        $this->assertTrue($mock->concreteMethod());
+        $this->assertTrue($double->concreteMethod());
     }
 
     public function testCannotCreateMockObjectForTraitThatDoesNotExist(): void
diff --git a/tests/unit/Framework/MockObject/Creation/GetMockFromWsdlTest.php b/tests/unit/Framework/MockObject/Creation/GetMockFromWsdlTest.php
@@ -26,11 +26,11 @@ final class GetMockFromWsdlTest extends TestCase
     #[TestDox('Creates mock object from WSDL file')]
     public function test_CreatesMockObjectFromWsdlFileWithNonNamespacedClassName(): void
     {
-        $mock = $this->getMockFromWsdl(TEST_FILES_PATH . 'GoogleSearch.wsdl');
+        $double = $this->getMockFromWsdl(TEST_FILES_PATH . 'GoogleSearch.wsdl');
 
         $this->assertStringStartsWith(
             'MockObject_GoogleSearch_',
-            $mock::class,
+            $double::class,
         );
     }
 }
diff --git a/tests/unit/Framework/MockObject/MockObjectTest.php b/tests/unit/Framework/MockObject/MockObjectTest.php

Original file line number	Diff line number	Diff line change
`@@ -24,15 +24,15 @@ final class CreateConfiguredMockTest extends TestCase`
`24`	`24`	`{`
`25`	`25`	`public function testCreatesMockObjectForInterfaceOrExtendableClassWithReturnValueConfigurationForMultipleMethods(): void`
`26`	`26`	`{`
`27`		`- $stub = $this->createConfiguredMock(`
	`27`	`+ $double = $this->createConfiguredMock(`
`28`	`28`	`InterfaceWithReturnTypeDeclaration::class,`
`29`	`29`	`[`
`30`	`30`	`'doSomething' => true,`
`31`	`31`	`'doSomethingElse' => 1,`
`32`	`32`	`],`
`33`	`33`	`);`
`34`	`34`
`35`		`- $this->assertTrue($stub->doSomething());`
`36`		`- $this->assertSame(1, $stub->doSomethingElse(0));`
	`35`	`+ $this->assertTrue($double->doSomething());`
	`36`	`+ $this->assertSame(1, $double->doSomethingElse(0));`
`37`	`37`	`}`
`38`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,11 +26,11 @@ final class CreatePartialMockTest extends TestCase`
`26`	`26`	`{`
`27`	`27`	`public function testCreatesPartialMockObjectForExtendableClass(): void`
`28`	`28`	`{`
`29`		`- $mock = $this->createPartialMock(ExtendableClass::class, ['doSomethingElse']);`
	`29`	`+ $double = $this->createPartialMock(ExtendableClass::class, ['doSomethingElse']);`
`30`	`30`
`31`		`- $mock->expects($this->once())->method('doSomethingElse')->willReturn(true);`
	`31`	`+ $double->expects($this->once())->method('doSomethingElse')->willReturn(true);`
`32`	`32`
`33`		`- $this->assertTrue($mock->doSomething());`
	`33`	`+ $this->assertTrue($double->doSomething());`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`public function testCannotCreatePartialMockObjectForExtendableClassWithDuplicateMethods(): void`
`@@ -43,10 +43,10 @@ public function testCannotCreatePartialMockObjectForExtendableClassWithDuplicate`
`43`	`43`
`44`	`44`	`public function testMethodOfPartialMockThatIsNotConfigurableCannotBeConfigured(): void`
`45`	`45`	`{`
`46`		`- $mock = $this->createPartialMock(ExtendableClass::class, ['doSomethingElse']);`
	`46`	`+ $double = $this->createPartialMock(ExtendableClass::class, ['doSomethingElse']);`
`47`	`47`
`48`	`48`	`try {`
`49`		`- $mock->expects($this->once())->method('doSomething')->willReturn(true);`
	`49`	`+ $double->expects($this->once())->method('doSomething')->willReturn(true);`
`50`	`50`	`} catch (MethodCannotBeConfiguredException $e) {`
`51`	`51`	`$this->assertSame('Trying to configure method "doSomething" which cannot be configured because it does not exist, has not been specified, is final, or is static', $e->getMessage());`
`52`	`52`
Original file line number	Diff line number	Diff line change
`@@ -25,14 +25,14 @@ final class CreateTestProxyTest extends TestCase`
`25`	`25`	`{`
`26`	`26`	`public function testCreatesTestProxyForExtendableClass(): void`
`27`	`27`	`{`
`28`		`- $proxy = $this->createTestProxy(TestProxyFixture::class);`
	`28`	`+ $double = $this->createTestProxy(TestProxyFixture::class);`
`29`	`29`
`30`		`- $proxy->expects($this->once())`
	`30`	`+ $double->expects($this->once())`
`31`	`31`	`->method('returnString');`
`32`	`32`
`33`		`- assert($proxy instanceof MockObject);`
`34`		`- assert($proxy instanceof TestProxyFixture);`
	`33`	`+ assert($double instanceof MockObject);`
	`34`	`+ assert($double instanceof TestProxyFixture);`
`35`	`35`
`36`		`- $this->assertSame('result', $proxy->returnString());`
	`36`	`+ $this->assertSame('result', $double->returnString());`
`37`	`37`	`}`
`38`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,11 +28,11 @@ final class GetMockForAbstractClassTest extends TestCase`
`28`	`28`	`{`
`29`	`29`	`public function testCreatesMockObjectForAbstractClassAndAllowsConfigurationOfAbstractMethods(): void`
`30`	`30`	`{`
`31`		`- $mock = $this->getMockForAbstractClass(AbstractClass::class);`
	`31`	`+ $double = $this->getMockForAbstractClass(AbstractClass::class);`
`32`	`32`
`33`		`- $mock->expects($this->once())->method('doSomethingElse')->willReturn(true);`
	`33`	`+ $double->expects($this->once())->method('doSomethingElse')->willReturn(true);`
`34`	`34`
`35`		`- $this->assertTrue($mock->doSomething());`
	`35`	`+ $this->assertTrue($double->doSomething());`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`public function testCannotCreateMockObjectForAbstractClassThatDoesNotExist(): void`
`@@ -45,10 +45,10 @@ public function testCannotCreateMockObjectForAbstractClassThatDoesNotExist(): vo`
`45`	`45`
`46`	`46`	`public function testCreatesMockObjectForAbstractClassAndDoesNotAllowConfigurationOfConcreteMethods(): void`
`47`	`47`	`{`
`48`		`- $mock = $this->getMockForAbstractClass(AbstractClass::class);`
	`48`	`+ $double = $this->getMockForAbstractClass(AbstractClass::class);`
`49`	`49`
`50`	`50`	`try {`
`51`		`- $mock->expects($this->once())->method('doSomething');`
	`51`	`+ $double->expects($this->once())->method('doSomething');`
`52`	`52`	`} catch (MethodCannotBeConfiguredException $e) {`
`53`	`53`	`$this->assertSame('Trying to configure method "doSomething" which cannot be configured because it does not exist, has not been specified, is final, or is static', $e->getMessage());`
`54`	`54`
Original file line number	Diff line number	Diff line change
`@@ -25,11 +25,11 @@ final class GetMockForTraitTest extends TestCase`
`25`	`25`	`{`
`26`	`26`	`public function testCreatesMockObjectForTraitAndAllowsConfigurationOfAbstractMethods(): void`
`27`	`27`	`{`
`28`		`- $mock = $this->getMockForTrait(TraitWithConcreteAndAbstractMethod::class);`
	`28`	`+ $double = $this->getMockForTrait(TraitWithConcreteAndAbstractMethod::class);`
`29`	`29`
`30`		`- $mock->method('abstractMethod')->willReturn(true);`
	`30`	`+ $double->method('abstractMethod')->willReturn(true);`
`31`	`31`
`32`		`- $this->assertTrue($mock->concreteMethod());`
	`32`	`+ $this->assertTrue($double->concreteMethod());`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`public function testCannotCreateMockObjectForTraitThatDoesNotExist(): void`
Original file line number	Diff line number	Diff line change
`@@ -26,11 +26,11 @@ final class GetMockFromWsdlTest extends TestCase`
`26`	`26`	`#[TestDox('Creates mock object from WSDL file')]`
`27`	`27`	`public function test_CreatesMockObjectFromWsdlFileWithNonNamespacedClassName(): void`
`28`	`28`	`{`
`29`		`- $mock = $this->getMockFromWsdl(TEST_FILES_PATH . 'GoogleSearch.wsdl');`
	`29`	`+ $double = $this->getMockFromWsdl(TEST_FILES_PATH . 'GoogleSearch.wsdl');`
`30`	`30`
`31`	`31`	`$this->assertStringStartsWith(`
`32`	`32`	`'MockObject_GoogleSearch_',`
`33`		`- $mock::class,`
	`33`	`+ $double::class,`
`34`	`34`	`);`
`35`	`35`	`}`
`36`	`36`	`}`