Fix PHPStan reported issues

Author: staabm

src/Framework/ExecutionOrderDependency.php

@@ -136,6 +136,9 @@ public static function diff(array $left, array $right): array
 
     public function __construct(string $classOrCallableName, ?string $methodName = null, bool $deepClone = false, bool $shallowClone = false)
     {
+        $this->deepClone    = $deepClone;
+        $this->shallowClone = $shallowClone;
+
         if ($classOrCallableName === '') {
             return;
         }
@@ -146,9 +149,6 @@ public function __construct(string $classOrCallableName, ?string $methodName = n
             $this->className  = $classOrCallableName;
             $this->methodName = !empty($methodName) ? $methodName : 'class';
         }
-
-        $this->deepClone    = $deepClone;
-        $this->shallowClone = $shallowClone;
     }
 
     public function __toString(): string

src/Framework/TestCase.php

@@ -1185,7 +1185,7 @@ protected function setLocale(mixed ...$arguments): void
             throw new Exception;
         }
 
-        $this->locale[$category] = setlocale($category, 0);
+        $this->locale[$category] = setlocale($category, '0');
 
         $result = setlocale(...$arguments);
 

src/Runner/Baseline/Reader.php

@@ -85,7 +85,6 @@ public function read(string $baselineFile): Baseline
 
                     $description = $issueElement->textContent;
 
-                    assert(!empty($file));
                     assert($line > 0);
                     assert(!empty($hash));
                     assert(!empty($description));

src/Runner/PhptTestCase.php

@@ -186,7 +186,9 @@ public function run(): void
         $jobResult    = $this->phpUtil->runJob($code, $this->stringifyIni($settings));
         $this->output = $jobResult['stdout'] ?? '';
 
-        if (CodeCoverage::instance()->isActive() && ($coverage = $this->cleanupForCoverage())) {
+        if (CodeCoverage::instance()->isActive()) {
+            $coverage = $this->cleanupForCoverage();
+
             CodeCoverage::instance()->codeCoverage()->start($this->filename, TestSize::large());
 
             CodeCoverage::instance()->codeCoverage()->append(

src/TextUI/Output/Printer/DefaultPrinter.php

@@ -69,6 +69,8 @@ public static function standardError(): self
      */
     private function __construct(string $out)
     {
+        $this->isPhpStream = str_starts_with($out, 'php://');
+
         if (str_starts_with($out, 'socket://')) {
             $tmp = explode(':', str_replace('socket://', '', $out));
 
@@ -87,8 +89,6 @@ private function __construct(string $out)
             return;
         }
 
-        $this->isPhpStream = str_starts_with($out, 'php://');
-
         if (!$this->isPhpStream && !Filesystem::createDirectory(dirname($out))) {
             throw new DirectoryDoesNotExistException(dirname($out));
         }