Do not use ReflectionProperty::setAccessible() with PHP >= 8.1

Author: sebastianbergmann

ChangeLog-9.6.md

@@ -6,6 +6,7 @@ All notable changes of the PHPUnit 9.6 release series are documented in this fil
 
 ### Changed
 
+* Do not use `ReflectionProperty::setAccessible()` with PHP >= 8.1
 * Do not use `SplObjectStorage` methods that will be deprecated in PHP 8.5
 
 ## [9.6.23] - 2025-05-02

tests/unit/Framework/Constraint/BinaryOperatorTestCase.php

@@ -9,6 +9,7 @@
  */
 namespace PHPUnit\Framework\Constraint;
 
+use const PHP_VERSION;
 use function array_fill;
 use function array_map;
 use function array_slice;
@@ -18,6 +19,7 @@
 use function implode;
 use function sprintf;
 use function str_split;
+use function version_compare;
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\TestFixture\BooleanConstraint;
 use PHPUnit\TestFixture\CountConstraint;
@@ -425,7 +427,10 @@ public function testFailureDescriptionWithSingleOperand(): void
             ->willReturn('is the only');
 
         $method = new ReflectionMethod($className, 'failureDescription');
-        $method->setAccessible(true);
+
+        if (version_compare(PHP_VERSION, '8.1.0', '<')) {
+            $method->setAccessible(true);
+        }
 
         $this->assertSame("'whatever' is the only", $method->invoke($operator, 'whatever'));
     }
@@ -533,7 +538,10 @@ public function testFailureDescriptionWithMultipleOperands(): void
             ->willReturn('is fifth or later');
 
         $method = new ReflectionMethod($className, 'failureDescription');
-        $method->setAccessible(true);
+
+        if (version_compare(PHP_VERSION, '8.1.0', '<')) {
+            $method->setAccessible(true);
+        }
 
         $expectedToString = self::operatorJoinStrings([
             'is first',

tests/unit/Framework/Constraint/UnaryOperatorTestCase.php

@@ -9,8 +9,10 @@
  */
 namespace PHPUnit\Framework\Constraint;
 
+use const PHP_VERSION;
 use function array_map;
 use function sprintf;
+use function version_compare;
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\TestFixture\BooleanConstraint;
 use PHPUnit\TestFixture\CountConstraint;
@@ -395,7 +397,10 @@ public function testFailureDescriptionWithNativeTransformations(string $input, s
         $constraint = new $className($operand);
 
         $method = (new ReflectionMethod($className, 'failureDescription'));
-        $method->setAccessible(true);
+
+        if (version_compare(PHP_VERSION, '8.1.0', '<')) {
+            $method->setAccessible(true);
+        }
 
         $this->assertSame("'whatever' " . $expected, $method->invokeArgs($constraint, ['whatever']));
     }
@@ -427,7 +432,10 @@ public function testFailureDescriptionWithNonContextualTerminalConstraint(): voi
             ->willReturn($string);
 
         $method = (new ReflectionMethod($className, 'failureDescription'));
-        $method->setAccessible(true);
+
+        if (version_compare(PHP_VERSION, '8.1.0', '<')) {
+            $method->setAccessible(true);
+        }
 
         $expected = "'whatever' " . $string;
 
@@ -459,7 +467,10 @@ public function testFailureDescriptionWithContextualTerminalConstraint(): void
             ->method('toString');
 
         $method = (new ReflectionMethod($className, 'failureDescription'));
-        $method->setAccessible(true);
+
+        if (version_compare(PHP_VERSION, '8.1.0', '<')) {
+            $method->setAccessible(true);
+        }
 
         $expected = "'whatever' " . $string;
 
@@ -499,7 +510,10 @@ public function testFailureDescriptionWithContextualUnaryOperator(): void
             ->method('toString');
 
         $method = (new ReflectionMethod($className, 'failureDescription'));
-        $method->setAccessible(true);
+
+        if (version_compare(PHP_VERSION, '8.1.0', '<')) {
+            $method->setAccessible(true);
+        }
 
         $expected = "'whatever' " . $string;
 
@@ -543,7 +557,10 @@ public function testFailureDescriptionWithNonContextualBinaryOperatorOfHigherPre
             ->willReturn($string);
 
         $method = (new ReflectionMethod($className, 'failureDescription'));
-        $method->setAccessible(true);
+
+        if (version_compare(PHP_VERSION, '8.1.0', '<')) {
+            $method->setAccessible(true);
+        }
 
         $expected = "'whatever' " . $string;
 
@@ -585,7 +602,10 @@ public function testFailureDescriptionWithContextualBinaryOperatorOfHigherPreced
             ->method('toString');
 
         $method = (new ReflectionMethod($className, 'failureDescription'));
-        $method->setAccessible(true);
+
+        if (version_compare(PHP_VERSION, '8.1.0', '<')) {
+            $method->setAccessible(true);
+        }
 
         $expected = "'whatever' " . $string;
 
@@ -627,7 +647,10 @@ public function testFailureDescriptionWithBinaryOperatorOfLowerPrecedence(): voi
             ->willReturn($string);
 
         $method = (new ReflectionMethod($className, 'failureDescription'));
-        $method->setAccessible(true);
+
+        if (version_compare(PHP_VERSION, '8.1.0', '<')) {
+            $method->setAccessible(true);
+        }
 
         $expected = $this->getOperatorName() . "( 'whatever' " . $string . ' )';
 

tests/unit/Framework/MockObject/MockObjectTest.php

@@ -1356,7 +1356,9 @@ private function resetMockObjects(): void
         $prop = $refl->getProperty('mockObjects');
 
         if (version_compare(PHP_VERSION, '8.1.0', '<')) {
-            $prop->setAccessible(true);
+            if (version_compare(PHP_VERSION, '8.1.0', '<')) {
+                $prop->setAccessible(true);
+            }
         }
 
         $prop->setValue($this, []);