Skip to content

Commit 3bfd16a

Browse files
Do not filter stack trace for deprecation triggers for E_DEPRECATED issues
1 parent 10ac9a7 commit 3bfd16a

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/Runner/ErrorHandler.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ public function __invoke(int $errorNumber, string $errorString, string $errorFil
148148
$suppressed,
149149
$ignoredByBaseline,
150150
$ignoredByTest,
151-
$this->trigger($test),
151+
$this->trigger($test, false),
152152
);
153153

154154
break;
@@ -162,7 +162,7 @@ public function __invoke(int $errorNumber, string $errorString, string $errorFil
162162
$suppressed,
163163
$ignoredByBaseline,
164164
$ignoredByTest,
165-
$this->trigger($test),
165+
$this->trigger($test, true),
166166
);
167167

168168
break;
@@ -246,13 +246,13 @@ private function ignoredByBaseline(string $file, int $line, string $description)
246246
return $this->baseline->has(Issue::from($file, $line, null, $description));
247247
}
248248

249-
private function trigger(TestMethod $test): IssueTrigger
249+
private function trigger(TestMethod $test, bool $filterTrigger): IssueTrigger
250250
{
251251
if (!$this->source->notEmpty()) {
252252
return IssueTrigger::unknown();
253253
}
254254

255-
$trace = $this->cleanedTrace();
255+
$trace = $this->cleanedTrace($filterTrigger);
256256

257257
assert(isset($trace[0]['file']));
258258
assert(isset($trace[1]['file']));
@@ -281,14 +281,14 @@ private function trigger(TestMethod $test): IssueTrigger
281281
return IssueTrigger::indirect();
282282
}
283283

284-
private function cleanedTrace(): array
284+
private function cleanedTrace(bool $filterTrigger): array
285285
{
286286
$trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
287287

288288
// self::cleanedTrace(), self::trigger(), self::__invoke()
289289
unset($trace[0], $trace[1], $trace[2]);
290290

291-
if ($this->deprecationTriggers === null) {
291+
if ($this->deprecationTriggers === null || !$filterTrigger) {
292292
return array_values($trace);
293293
}
294294

0 commit comments

Comments
 (0)