Skip to content

Commit 567c57f

Browse files
localheinzsebastianbergmann
authored andcommitted
Fix: Remove conditions from test
1 parent d89d230 commit 567c57f

File tree

1 file changed

+29
-49
lines changed

1 file changed

+29
-49
lines changed

tests/unit/Metadata/Facade/CodeCoverageFacadeTest.php

Lines changed: 29 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -44,47 +44,8 @@ final class CodeCoverageFacadeTest extends TestCase
4444
* @psalm-param class-string $test
4545
*/
4646
#[DataProvider('getLinesToBeCoveredProvider')]
47-
public function testGetLinesToBeCovered(string $test, array|false $lines): void
47+
public function testGetLinesToBeCovered(string $test, array|false $expected): void
4848
{
49-
switch ($test) {
50-
case CoverageMethodNothingCoversMethod::class:
51-
case CoverageClassNothingTest::class:
52-
case CoverageMethodNothingTest::class:
53-
$expected = false;
54-
55-
break;
56-
57-
case CoverageCoversOverridesCoversNothingTest::class:
58-
$expected = [TEST_FILES_PATH . 'CoveredClass.php' => $lines];
59-
60-
break;
61-
62-
case CoverageNoneTest::class:
63-
$expected = [];
64-
65-
break;
66-
67-
case CoverageFunctionTest::class:
68-
$expected = [
69-
TEST_FILES_PATH . 'CoveredFunction.php' => $lines,
70-
];
71-
72-
break;
73-
74-
case NamespaceCoverageClassTest::class:
75-
case NamespaceCoverageMethodTest::class:
76-
case NamespaceCoverageCoversClassTest::class:
77-
case NamespaceCoverageCoversClassPublicTest::class:
78-
$expected = [
79-
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => $lines,
80-
];
81-
82-
break;
83-
84-
default:
85-
$expected = [TEST_FILES_PATH . 'CoveredClass.php' => $lines];
86-
}
87-
8849
$this->assertEqualsCanonicalizing(
8950
$expected,
9051
(new CodeCoverage)->linesToBeCovered(
@@ -160,35 +121,52 @@ public function getLinesToBeCoveredProvider(): array
160121
],
161122
[
162123
CoverageClassTest::class,
163-
range(29, 46),
124+
[
125+
TEST_FILES_PATH . 'CoveredClass.php' => range(29, 46),
126+
],
164127
],
165128
[
166129
CoverageMethodTest::class,
167-
range(31, 35),
130+
[
131+
TEST_FILES_PATH . 'CoveredClass.php' => range(31, 35),
132+
],
168133
],
169134
[
170135
CoverageMethodOneLineAnnotationTest::class,
171-
range(31, 35),
136+
[
137+
TEST_FILES_PATH . 'CoveredClass.php' => range(31, 35),
138+
],
172139
],
173140
[
174141
CoverageFunctionTest::class,
175-
range(10, 12),
142+
[
143+
TEST_FILES_PATH . 'CoveredFunction.php' => range(10, 12),
144+
],
176145
],
177146
[
178147
NamespaceCoverageClassTest::class,
179-
range(29, 46),
148+
[
149+
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => range(29, 46),
150+
],
180151
],
181152
[
182153
NamespaceCoverageMethodTest::class,
183-
range(31, 35),
154+
[
155+
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => range(31, 35),
156+
],
184157
],
185158
[
186159
NamespaceCoverageCoversClassTest::class,
187-
array_merge(range(43, 45), range(37, 41), range(31, 35), range(24, 26), range(19, 22), range(14, 17)),
160+
[
161+
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => array_merge(range(43, 45), range(37, 41), range(31, 35), range(24, 26), range(19, 22), range(14, 17)),
162+
],
188163
],
189164
[
190165
NamespaceCoverageCoversClassPublicTest::class,
191-
range(31, 35),
166+
[
167+
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => range(31, 35),
168+
],
169+
192170
],
193171
[
194172
CoverageClassNothingTest::class,
@@ -200,7 +178,9 @@ public function getLinesToBeCoveredProvider(): array
200178
],
201179
[
202180
CoverageCoversOverridesCoversNothingTest::class,
203-
range(31, 35),
181+
[
182+
TEST_FILES_PATH . 'CoveredClass.php' => range(31, 35),
183+
],
204184
],
205185
[
206186
CoverageMethodNothingCoversMethod::class,

0 commit comments

Comments
 (0)