Use stricter comparison

Author: sebastianbergmann

src/Framework/TestRunner/TestRunner.php

@@ -283,7 +283,7 @@ private function shouldTimeLimitBeEnforced(TestCase $test): bool
             return false;
         }
 
-        if (!(($this->configuration->defaultTimeLimit() || $test->size()->isKnown()))) {
+        if (!(($this->configuration->defaultTimeLimit() > 0 || $test->size()->isKnown()))) {
             return false;
         }
 

src/Logging/EventLogger.php

@@ -41,15 +41,19 @@ public function trace(Event $event): void
     {
         $telemetryInfo = $this->telemetryInfo($event);
         $indentation   = PHP_EOL . str_repeat(' ', strlen($telemetryInfo));
-        $lines         = preg_split('/\r\n|\r|\n/', $event->asString()) ?: [];
-
-        $flags = FILE_APPEND;
+        $flags         = FILE_APPEND;
 
         if (!(PHP_OS_FAMILY === 'Windows' || PHP_OS_FAMILY === 'Darwin') ||
             $this->path !== 'php://stdout') {
             $flags |= LOCK_EX;
         }
 
+        $lines = preg_split('/\r\n|\r|\n/', $event->asString());
+
+        if ($lines === false) {
+            $lines = [];
+        }
+
         file_put_contents(
             $this->path,
             $telemetryInfo . implode($indentation, $lines) . PHP_EOL,

src/Logging/JUnit/JunitXmlLogger.php

@@ -104,8 +104,13 @@ public function __construct(Printer $printer, Facade $facade)
 
     public function flush(): void
     {
-        $this->printer->print($this->document->saveXML() ?: '');
+        $xml = $this->document->saveXML();
 
+        if ($xml === false) {
+            $xml = '';
+        }
+
+        $this->printer->print($xml);
         $this->printer->flush();
     }
 

src/Metadata/Api/Requirements.php

@@ -70,9 +70,15 @@ public function requirementsNotSatisfiedFor(string $className, string $methodNam
             if ($metadata->isRequiresPhpExtension()) {
                 assert($metadata instanceof RequiresPhpExtension);
 
+                $extensionVersion = phpversion($metadata->extension());
+
+                if ($extensionVersion === false) {
+                    $extensionVersion = '';
+                }
+
                 if (!extension_loaded($metadata->extension()) ||
                     ($metadata->hasVersionRequirement() &&
-                        !$metadata->versionRequirement()->isSatisfiedBy(phpversion($metadata->extension()) ?: ''))) {
+                    !$metadata->versionRequirement()->isSatisfiedBy($extensionVersion))) {
                     $notSatisfied[] = sprintf(
                         'PHP extension %s%s is required.',
                         $metadata->extension(),

src/Runner/BackedUpEnvironmentVariable.php

@@ -40,9 +40,15 @@
      */
     public static function create(string $name): array
     {
+        $getenv = getenv($name);
+
+        if ($getenv === false) {
+            $getenv = null;
+        }
+
         return [
             new self(self::FROM_SUPERGLOBAL, $name, $_ENV[$name] ?? null),
-            new self(self::FROM_GETENV, $name, getenv($name) ?: null),
+            new self(self::FROM_GETENV, $name, $getenv),
         ];
     }