Skip to content

Commit 6fec4ae

Browse files
localheinzsebastianbergmann
localheinz
authored and
sebastianbergmann
committed
Fix: Remove conditions from test
1 parent d88e9a8 commit 6fec4ae

File tree

1 file changed

+77
-47
lines changed

1 file changed

+77
-47
lines changed

‎tests/unit/Util/TestClassTest.php

Lines changed: 77 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
use function preg_match;
1414
use function range;
1515
use function realpath;
16-
use function strpos;
1716
use CoverageNamespacedFunctionTest;
1817
use DuplicateKeyDataProviderTest;
1918
use MultipleDataProviderTest;
@@ -1160,30 +1159,8 @@ public function methodForTestParseAnnotationThatIsOnlyOneLine(): void
11601159
* @throws \SebastianBergmann\RecursionContext\InvalidArgumentException
11611160
* @throws CodeCoverageException
11621161
*/
1163-
public function testGetLinesToBeCovered($test, $lines): void
1162+
public function testGetLinesToBeCovered($test, $expected): void
11641163
{
1165-
if (strpos($test, 'Namespace') === 0) {
1166-
$expected = [
1167-
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => $lines,
1168-
];
1169-
} elseif ($test === 'CoverageMethodNothingCoversMethod') {
1170-
$expected = false;
1171-
} elseif ($test === 'CoverageCoversOverridesCoversNothingTest') {
1172-
$expected = [TEST_FILES_PATH . 'CoveredClass.php' => $lines];
1173-
} elseif ($test === 'CoverageNoneTest') {
1174-
$expected = [];
1175-
} elseif ($test === 'CoverageClassNothingTest') {
1176-
$expected = false;
1177-
} elseif ($test === 'CoverageMethodNothingTest') {
1178-
$expected = false;
1179-
} elseif ($test === 'CoverageFunctionTest') {
1180-
$expected = [
1181-
TEST_FILES_PATH . 'CoveredFunction.php' => $lines,
1182-
];
1183-
} else {
1184-
$expected = [TEST_FILES_PATH . 'CoveredClass.php' => $lines];
1185-
}
1186-
11871164
$this->assertEquals(
11881165
$expected,
11891166
Test::getLinesToBeCovered(
@@ -1310,91 +1287,142 @@ public function getLinesToBeCoveredProvider(): array
13101287
],
13111288
[
13121289
'CoverageClassExtendedTest',
1313-
array_merge(range(27, 44), range(10, 25)),
1290+
[
1291+
TEST_FILES_PATH . 'CoveredClass.php' => array_merge(range(27, 44), range(10, 25)),
1292+
],
13141293
],
13151294
[
13161295
'CoverageClassTest',
1317-
range(27, 44),
1296+
[
1297+
TEST_FILES_PATH . 'CoveredClass.php' => range(27, 44),
1298+
],
13181299
],
13191300
[
13201301
'CoverageMethodTest',
1321-
range(29, 33),
1302+
[
1303+
TEST_FILES_PATH . 'CoveredClass.php' => range(29, 33),
1304+
],
13221305
],
13231306
[
13241307
'CoverageMethodOneLineAnnotationTest',
1325-
range(29, 33),
1308+
[
1309+
TEST_FILES_PATH . 'CoveredClass.php' => range(29, 33),
1310+
],
1311+
13261312
],
13271313
[
13281314
'CoverageNotPrivateTest',
1329-
array_merge(range(29, 33), range(35, 39)),
1315+
[
1316+
TEST_FILES_PATH . 'CoveredClass.php' => array_merge(range(29, 33), range(35, 39)),
1317+
],
1318+
13301319
],
13311320
[
13321321
'CoverageNotProtectedTest',
1333-
array_merge(range(29, 33), range(41, 43)),
1322+
[
1323+
TEST_FILES_PATH . 'CoveredClass.php' => array_merge(range(29, 33), range(41, 43)),
1324+
],
1325+
13341326
],
13351327
[
13361328
'CoverageNotPublicTest',
1337-
array_merge(range(35, 39), range(41, 43)),
1329+
[
1330+
TEST_FILES_PATH . 'CoveredClass.php' => array_merge(range(35, 39), range(41, 43)),
1331+
],
1332+
13381333
],
13391334
[
13401335
'CoveragePrivateTest',
1341-
range(41, 43),
1336+
[
1337+
TEST_FILES_PATH . 'CoveredClass.php' => range(41, 43),
1338+
],
1339+
13421340
],
13431341
[
13441342
'CoverageProtectedTest',
1345-
range(35, 39),
1343+
[
1344+
TEST_FILES_PATH . 'CoveredClass.php' => range(35, 39),
1345+
],
1346+
13461347
],
13471348
[
13481349
'CoveragePublicTest',
1349-
range(29, 33),
1350+
[
1351+
TEST_FILES_PATH . 'CoveredClass.php' => range(29, 33),
1352+
],
1353+
13501354
],
13511355
[
13521356
'CoverageFunctionTest',
1353-
range(10, 12),
1357+
[
1358+
TEST_FILES_PATH . 'CoveredFunction.php' => range(10, 12),
1359+
],
13541360
],
13551361
[
13561362
'NamespaceCoverageClassExtendedTest',
1357-
array_merge(range(29, 46), range(12, 27)),
1363+
[
1364+
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => array_merge(range(29, 46), range(12, 27)),
1365+
],
13581366
],
13591367
[
13601368
'NamespaceCoverageClassTest',
1361-
range(29, 46),
1369+
[
1370+
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => range(29, 46),
1371+
],
13621372
],
13631373
[
13641374
'NamespaceCoverageMethodTest',
1365-
range(31, 35),
1375+
[
1376+
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => range(31, 35),
1377+
],
13661378
],
13671379
[
13681380
'NamespaceCoverageNotPrivateTest',
1369-
array_merge(range(31, 35), range(37, 41)),
1381+
[
1382+
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => array_merge(range(31, 35), range(37, 41)),
1383+
],
13701384
],
13711385
[
13721386
'NamespaceCoverageNotProtectedTest',
1373-
array_merge(range(31, 35), range(43, 45)),
1387+
[
1388+
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => array_merge(range(31, 35), range(43, 45)),
1389+
],
13741390
],
13751391
[
13761392
'NamespaceCoverageNotPublicTest',
1377-
array_merge(range(37, 41), range(43, 45)),
1393+
[
1394+
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => array_merge(range(37, 41), range(43, 45)),
1395+
],
13781396
],
13791397
[
13801398
'NamespaceCoveragePrivateTest',
1381-
range(43, 45),
1399+
[
1400+
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => range(43, 45),
1401+
],
13821402
],
13831403
[
13841404
'NamespaceCoverageProtectedTest',
1385-
range(37, 41),
1405+
[
1406+
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => range(37, 41),
1407+
],
13861408
],
13871409
[
13881410
'NamespaceCoveragePublicTest',
1389-
range(31, 35),
1411+
[
1412+
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => range(31, 35),
1413+
],
13901414
],
13911415
[
13921416
'NamespaceCoverageCoversClassTest',
1393-
array_merge(range(43, 45), range(37, 41), range(31, 35), range(24, 26), range(19, 22), range(14, 17)),
1417+
[
1418+
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => array_merge(range(43, 45), range(37, 41), range(31, 35), range(24, 26), range(19, 22), range(14, 17)),
1419+
],
13941420
],
13951421
[
13961422
'NamespaceCoverageCoversClassPublicTest',
1397-
range(31, 35),
1423+
[
1424+
TEST_FILES_PATH . 'NamespaceCoveredClass.php' => range(31, 35),
1425+
],
13981426
],
13991427
[
14001428
'CoverageClassNothingTest',
@@ -1406,7 +1434,9 @@ public function getLinesToBeCoveredProvider(): array
14061434
],
14071435
[
14081436
'CoverageCoversOverridesCoversNothingTest',
1409-
range(29, 33),
1437+
[
1438+
TEST_FILES_PATH . 'CoveredClass.php' => range(29, 33),
1439+
],
14101440
],
14111441
[
14121442
'CoverageMethodNothingCoversMethod',

0 commit comments

Comments
 (0)