Do not use empty()

Author: sebastianbergmann

src/Event/Value/ComparisonFailureBuilder.php

@@ -34,13 +34,13 @@ public static function from(Throwable $t): ?ComparisonFailure
 
         $expectedAsString = $t->getComparisonFailure()->getExpectedAsString();
 
-        if (empty($expectedAsString)) {
+        if ($expectedAsString === '') {
             $expectedAsString = self::mapScalarValueToString($t->getComparisonFailure()->getExpected());
         }
 
         $actualAsString = $t->getComparisonFailure()->getActualAsString();
 
-        if (empty($actualAsString)) {
+        if ($actualAsString === '') {
             $actualAsString = self::mapScalarValueToString($t->getComparisonFailure()->getActual());
         }
 

src/Framework/MockObject/Runtime/Stub/ConsecutiveCalls.php

@@ -41,7 +41,7 @@ public function __construct(array $stack)
      */
     public function invoke(Invocation $invocation): mixed
     {
-        if (empty($this->stack)) {
+        if ($this->stack === []) {
             throw new NoMoreReturnValuesConfiguredException(
                 $invocation,
                 $this->numberOfConfiguredReturnValues,

src/Framework/TestCase.php

@@ -847,7 +847,7 @@ final public function dataSetAsString(): string
      */
     final public function dataSetAsStringWithData(): string
     {
-        if (empty($this->data)) {
+        if ($this->data === []) {
             return '';
         }
 

src/Framework/TestSuite.php

@@ -579,7 +579,7 @@ private function throwableToString(Throwable $t): string
     {
         $message = $t->getMessage();
 
-        if (empty(trim($message))) {
+        if (trim($message) === '') {
             $message = '<no message>';
         }
 

src/Logging/TestDox/NamePrettifier.php

@@ -89,7 +89,7 @@ public function prettifyTestClassName(string $className): string
             $className = substr($className, strlen('Test'));
         }
 
-        if (empty($className)) {
+        if ($className === '') {
             $className = 'UnnamedTests';
         }
 

src/Metadata/Api/Dependencies.php

@@ -43,7 +43,7 @@ public static function dependencies(string $className, string $methodName): arra
 
             assert($metadata instanceof DependsOnMethod);
 
-            if (empty($metadata->methodName())) {
+            if ($metadata->methodName() === '') {
                 $dependencies[] = ExecutionOrderDependency::invalid();
 
                 continue;

src/Metadata/Version/Requirement.php

@@ -42,7 +42,7 @@ public static function from(string $versionRequirement): self
                 return new ComparisonRequirement(
                     $matches['version'],
                     new VersionComparisonOperator(
-                        !empty($matches['operator']) ? $matches['operator'] : '>=',
+                        $matches['operator'] !== '' ? $matches['operator'] : '>=',
                     ),
                 );
             }

src/Runner/PHPT/PhptTestCase.php

@@ -569,7 +569,7 @@ private function parse(): array
                 continue;
             }
 
-            if (empty($section)) {
+            if ($section === '') {
                 throw new InvalidPhptFileException;
             }
 
@@ -880,7 +880,7 @@ private function locationHint(string $needle, array $sections): array
     {
         $needle = trim($needle);
 
-        if (empty($needle)) {
+        if ($needle === '') {
             return [[
                 'file' => realpath($this->filename),
                 'line' => 1,

src/Runner/TestSuiteSorter.php

@@ -136,7 +136,7 @@ public function getExecutionOrder(): array
 
     private function sort(TestSuite $suite, int $order, bool $resolveDependencies, int $orderDefects): void
     {
-        if (empty($suite->tests())) {
+        if ($suite->tests() === []) {
             return;
         }