Micro optimize NamePrettifier->prettifyTestMethodName() once again

staabm · sebastianbergmann · commit a0ad5623b6b5 · 2024-03-15T05:58:33.000+01:00
diff --git a/src/Logging/TestDox/NamePrettifier.php b/src/Logging/TestDox/NamePrettifier.php
@@ -114,11 +114,10 @@ public function prettifyTestMethodName(string $name): string
             return '';
         }
 
-        $string = (string) preg_replace('#\d+$#', '', $name, -1, $count);
-
+        $string = rtrim($name, '0123456789');
         if (array_key_exists($string, self::$strings)) {
             $name = $string;
-        } elseif ($count === 0) {
+        } elseif ($string === $name) {
             self::$strings[$string] = 1;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -114,11 +114,10 @@ public function prettifyTestMethodName(string $name): string`
`114`	`114`	`return '';`
`115`	`115`	`}`
`116`	`116`
`117`		`- $string = (string) preg_replace('#\d+$#', '', $name, -1, $count);`
`118`		`-`
	`117`	`+ $string = rtrim($name, '0123456789');`
`119`	`118`	`if (array_key_exists($string, self::$strings)) {`
`120`	`119`	`$name = $string;`
`121`		`- } elseif ($count === 0) {`
	`120`	`+ } elseif ($string === $name) {`
`122`	`121`	`self::$strings[$string] = 1;`
`123`	`122`	`}`
`124`	`123`