Refactor

Author: sebastianbergmann

src/TextUI/Application.php

@@ -271,14 +271,7 @@ public function run(array $argv): int
             }
 
             $shellExitCode = (new ShellExitCodeCalculator)->calculate(
-                $configuration->failOnDeprecation() || $configuration->failOnAllIssues(),
-                $configuration->failOnPhpunitDeprecation() || $configuration->failOnAllIssues(),
-                $configuration->failOnEmptyTestSuite() || $configuration->failOnAllIssues(),
-                $configuration->failOnIncomplete() || $configuration->failOnAllIssues(),
-                $configuration->failOnNotice() || $configuration->failOnAllIssues(),
-                $configuration->failOnRisky() || $configuration->failOnAllIssues(),
-                $configuration->failOnSkipped() || $configuration->failOnAllIssues(),
-                $configuration->failOnWarning() || $configuration->failOnAllIssues(),
+                $configuration,
                 $result,
             );
 

src/TextUI/ShellExitCodeCalculator.php

@@ -10,6 +10,7 @@
 namespace PHPUnit\TextUI;
 
 use PHPUnit\TestRunner\TestResult\TestResult;
+use PHPUnit\TextUI\Configuration\Configuration;
 
 /**
  * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
@@ -22,8 +23,17 @@ final class ShellExitCodeCalculator
     private const FAILURE_EXIT   = 1;
     private const EXCEPTION_EXIT = 2;
 
-    public function calculate(bool $failOnDeprecation, bool $failOnPhpunitDeprecation, bool $failOnEmptyTestSuite, bool $failOnIncomplete, bool $failOnNotice, bool $failOnRisky, bool $failOnSkipped, bool $failOnWarning, TestResult $result): int
+    public function calculate(Configuration $configuration, TestResult $result): int
     {
+        $failOnDeprecation        = $configuration->failOnDeprecation() || $configuration->failOnAllIssues();
+        $failOnPhpunitDeprecation = $configuration->failOnPhpunitDeprecation() || $configuration->failOnAllIssues();
+        $failOnEmptyTestSuite     = $configuration->failOnEmptyTestSuite() || $configuration->failOnAllIssues();
+        $failOnIncomplete         = $configuration->failOnIncomplete() || $configuration->failOnAllIssues();
+        $failOnNotice             = $configuration->failOnNotice() || $configuration->failOnAllIssues();
+        $failOnRisky              = $configuration->failOnRisky() || $configuration->failOnAllIssues();
+        $failOnSkipped            = $configuration->failOnSkipped() || $configuration->failOnAllIssues();
+        $failOnWarning            = $configuration->failOnWarning() || $configuration->failOnAllIssues();
+
         $returnCode = self::FAILURE_EXIT;
 
         if ($result->wasSuccessful()) {