Skip to content

Commit a40a51b

Browse files
staabmsebastianbergmann
authored andcommitted
More precise param types in TestBuilder
1 parent 83c7c23 commit a40a51b

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/Framework/TestBuilder.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
final readonly class TestBuilder
2929
{
3030
/**
31+
* @psalm-param ReflectionClass<TestCase> $theClass
3132
* @psalm-param non-empty-string $methodName
3233
* @psalm-param list<non-empty-string> $groups
3334
*
@@ -71,7 +72,7 @@ public function build(ReflectionClass $theClass, string $methodName, array $grou
7172
}
7273

7374
/**
74-
* @psalm-param class-string $className
75+
* @psalm-param class-string<TestCase> $className
7576
* @psalm-param non-empty-string $methodName
7677
* @psalm-param array{backupGlobals: ?bool, backupGlobalsExcludeList: list<string>, backupStaticProperties: ?bool, backupStaticPropertiesExcludeList: array<string,list<string>>} $backupSettings
7778
* @psalm-param list<non-empty-string> $groups
@@ -143,7 +144,7 @@ private function configureTestCase(TestCase $test, bool $runTestInSeparateProces
143144
}
144145

145146
/**
146-
* @psalm-param class-string $className
147+
* @psalm-param class-string<TestCase> $className
147148
* @psalm-param non-empty-string $methodName
148149
*
149150
* @psalm-return array{backupGlobals: ?bool, backupGlobalsExcludeList: list<string>, backupStaticProperties: ?bool, backupStaticPropertiesExcludeList: array<string,list<string>>}
@@ -221,7 +222,7 @@ private function backupSettings(string $className, string $methodName): array
221222
}
222223

223224
/**
224-
* @psalm-param class-string $className
225+
* @psalm-param class-string<TestCase> $className
225226
* @psalm-param non-empty-string $methodName
226227
*/
227228
private function shouldGlobalStateBePreserved(string $className, string $methodName): ?bool
@@ -250,7 +251,7 @@ private function shouldGlobalStateBePreserved(string $className, string $methodN
250251
}
251252

252253
/**
253-
* @psalm-param class-string $className
254+
* @psalm-param class-string<TestCase> $className
254255
* @psalm-param non-empty-string $methodName
255256
*/
256257
private function shouldTestMethodBeRunInSeparateProcess(string $className, string $methodName): bool
@@ -267,7 +268,7 @@ private function shouldTestMethodBeRunInSeparateProcess(string $className, strin
267268
}
268269

269270
/**
270-
* @psalm-param class-string $className
271+
* @psalm-param class-string<TestCase> $className
271272
*/
272273
private function shouldAllTestMethodsOfTestClassBeRunInSingleSeparateProcess(string $className): bool
273274
{

0 commit comments

Comments
 (0)