Refactor

Author: sebastianbergmann

src/Framework/TestRunner/TestRunner.php

@@ -70,10 +70,7 @@ public function run(TestCase $test): void
             $test->name(),
         );
 
-        $shouldCodeCoverageBeCollected = $codeCoverageMetadataApi->shouldCodeCoverageBeCollectedFor(
-            $test::class,
-            $test->name(),
-        );
+        $shouldCodeCoverageBeCollected = $codeCoverageMetadataApi->shouldCodeCoverageBeCollectedFor($test);
 
         $this->performSanityChecks($test, $coversTargets, $usesTargets, $shouldCodeCoverageBeCollected);
 

src/Metadata/Api/CodeCoverage.php

@@ -10,6 +10,7 @@
 namespace PHPUnit\Metadata\Api;
 
 use function assert;
+use PHPUnit\Framework\TestCase;
 use PHPUnit\Metadata\CoversClass;
 use PHPUnit\Metadata\CoversClassesThatExtendClass;
 use PHPUnit\Metadata\CoversClassesThatImplementInterface;
@@ -145,20 +146,17 @@ public function usesTargets(string $className, string $methodName): TargetCollec
         return TargetCollection::fromArray($targets);
     }
 
-    /**
-     * @param class-string     $className
-     * @param non-empty-string $methodName
-     */
-    public function shouldCodeCoverageBeCollectedFor(string $className, string $methodName): bool
+    public function shouldCodeCoverageBeCollectedFor(TestCase $test): bool
     {
-        $metadataForClass  = Registry::parser()->forClass($className);
-        $metadataForMethod = Registry::parser()->forMethod($className, $methodName);
+        $className  = $test::class;
+        $methodName = $test->name();
+        $parser     = Registry::parser();
 
-        if ($metadataForMethod->isCoversNothing()->isNotEmpty()) {
+        if ($parser->forMethod($className, $methodName)->isCoversNothing()->isNotEmpty()) {
             return false;
         }
 
-        if ($metadataForClass->isCoversNothing()->isNotEmpty()) {
+        if ($parser->forClass($className)->isCoversNothing()->isNotEmpty()) {
             return false;
         }
 

tests/unit/Metadata/Api/CodeCoverageTest.php

@@ -135,7 +135,7 @@ public function testMapsUsesMetadataToCodeCoverageTargetCollection(): void
     public function testWhetherCollectionOfCodeCoverageDataCanBeSkippedCanBeDetermined(bool $expected, string $testCase): void
     {
         $test             = new $testCase('testSomething');
-        $coverageRequired = (new CodeCoverage)->shouldCodeCoverageBeCollectedFor($test::class, $test->name());
+        $coverageRequired = (new CodeCoverage)->shouldCodeCoverageBeCollectedFor($test);
         $canSkipCoverage  = !$coverageRequired;
 
         $this->assertSame($expected, $canSkipCoverage);