Change PHP_INT_MAX to null and update end-to-end tests

Author: kubawerlos

src/Framework/MockObject/Generator/MockMethod.php

@@ -9,7 +9,6 @@
  */
 namespace PHPUnit\Framework\MockObject\Generator;
 
-use const PHP_INT_MAX;
 use function count;
 use function explode;
 use function implode;
@@ -216,7 +215,7 @@ public function generateCode(): string
         $argumentsCount = 0;
 
         if (str_contains($this->argumentsForCall, '...')) {
-            $argumentsCount = PHP_INT_MAX; // @todo: change it to null and update end-to-end tests
+            $argumentsCount = null;
         } elseif (!empty($this->argumentsForCall)) {
             $argumentsCount = substr_count($this->argumentsForCall, ',') + 1;
         }

src/Framework/MockObject/Generator/templates/doubled_method.tpl

@@ -17,7 +17,7 @@
         $__phpunit_arguments = [{arguments_call}];
         $__phpunit_count     = func_num_args();
 
-        if ($__phpunit_count > {arguments_count}) {
+        if ({arguments_count} !== null && $__phpunit_count > {arguments_count}) {
             $__phpunit_arguments_tmp = func_get_args();
 
             for ($__phpunit_i = {arguments_count}; $__phpunit_i < $__phpunit_count; $__phpunit_i++) {

tests/end-to-end/mock-objects/generator/232.phpt

@@ -80,7 +80,7 @@ class MockFoo extends Foo implements PHPUnit\Framework\MockObject\MockObjectInte
         $__phpunit_arguments = [];
         $__phpunit_count     = func_num_args();
 
-        if ($__phpunit_count > 0) {
+        if (0 !== null && $__phpunit_count > 0) {
             $__phpunit_arguments_tmp = func_get_args();
 
             for ($__phpunit_i = 0; $__phpunit_i < $__phpunit_count; $__phpunit_i++) {

tests/end-to-end/mock-objects/generator/3154_namespaced_constant_resolving.phpt

@@ -65,7 +65,7 @@ class Issue3154Mock extends Is\Namespaced\Issue3154 implements PHPUnit\Framework
         $__phpunit_arguments = [$i, $j, $v, $z];
         $__phpunit_count     = func_num_args();
 
-        if ($__phpunit_count > 4) {
+        if (4 !== null && $__phpunit_count > 4) {
             $__phpunit_arguments_tmp = func_get_args();
 
             for ($__phpunit_i = 4; $__phpunit_i < $__phpunit_count; $__phpunit_i++) {

tests/end-to-end/mock-objects/generator/3967.phpt

@@ -53,7 +53,7 @@ class MockBaz extends Exception implements Baz, PHPUnit\Framework\MockObject\Moc
         $__phpunit_arguments = [];
         $__phpunit_count     = func_num_args();
 
-        if ($__phpunit_count > 0) {
+        if (0 !== null && $__phpunit_count > 0) {
             $__phpunit_arguments_tmp = func_get_args();
 
             for ($__phpunit_i = 0; $__phpunit_i < $__phpunit_count; $__phpunit_i++) {

tests/end-to-end/mock-objects/generator/397.phpt

@@ -51,7 +51,7 @@ class MockC extends C implements PHPUnit\Framework\MockObject\MockObjectInternal
         $__phpunit_arguments = [$other];
         $__phpunit_count     = func_num_args();
 
-        if ($__phpunit_count > 1) {
+        if (1 !== null && $__phpunit_count > 1) {
             $__phpunit_arguments_tmp = func_get_args();
 
             for ($__phpunit_i = 1; $__phpunit_i < $__phpunit_count; $__phpunit_i++) {

tests/end-to-end/mock-objects/generator/4139.phpt

@@ -41,7 +41,7 @@ class %s implements PHPUnit\Framework\MockObject\MockObjectInternal, InterfaceWi
         $__phpunit_arguments = [];
         $__phpunit_count     = func_num_args();
 
-        if ($__phpunit_count > 0) {
+        if (0 !== null && $__phpunit_count > 0) {
             $__phpunit_arguments_tmp = func_get_args();
 
             for ($__phpunit_i = 0; $__phpunit_i < $__phpunit_count; $__phpunit_i++) {

tests/end-to-end/mock-objects/generator/abstract_class.phpt

@@ -55,7 +55,7 @@ class MockFoo extends Foo implements PHPUnit\Framework\MockObject\MockObjectInte
         $__phpunit_arguments = [];
         $__phpunit_count     = func_num_args();
 
-        if ($__phpunit_count > 0) {
+        if (0 !== null && $__phpunit_count > 0) {
             $__phpunit_arguments_tmp = func_get_args();
 
             for ($__phpunit_i = 0; $__phpunit_i < $__phpunit_count; $__phpunit_i++) {
@@ -92,7 +92,7 @@ class MockFoo extends Foo implements PHPUnit\Framework\MockObject\MockObjectInte
         $__phpunit_arguments = [];
         $__phpunit_count     = func_num_args();
 
-        if ($__phpunit_count > 0) {
+        if (0 !== null && $__phpunit_count > 0) {
             $__phpunit_arguments_tmp = func_get_args();
 
             for ($__phpunit_i = 0; $__phpunit_i < $__phpunit_count; $__phpunit_i++) {
@@ -129,7 +129,7 @@ class MockFoo extends Foo implements PHPUnit\Framework\MockObject\MockObjectInte
         $__phpunit_arguments = [];
         $__phpunit_count     = func_num_args();
 
-        if ($__phpunit_count > 0) {
+        if (0 !== null && $__phpunit_count > 0) {
             $__phpunit_arguments_tmp = func_get_args();
 
             for ($__phpunit_i = 0; $__phpunit_i < $__phpunit_count; $__phpunit_i++) {

tests/end-to-end/mock-objects/generator/class.phpt

@@ -55,7 +55,7 @@ class MockFoo extends Foo implements PHPUnit\Framework\MockObject\MockObjectInte
         $__phpunit_arguments = [$foo];
         $__phpunit_count     = func_num_args();
 
-        if ($__phpunit_count > 1) {
+        if (1 !== null && $__phpunit_count > 1) {
             $__phpunit_arguments_tmp = func_get_args();
 
             for ($__phpunit_i = 1; $__phpunit_i < $__phpunit_count; $__phpunit_i++) {
@@ -92,7 +92,7 @@ class MockFoo extends Foo implements PHPUnit\Framework\MockObject\MockObjectInte
         $__phpunit_arguments = [$foo];
         $__phpunit_count     = func_num_args();
 
-        if ($__phpunit_count > 1) {
+        if (1 !== null && $__phpunit_count > 1) {
             $__phpunit_arguments_tmp = func_get_args();
 
             for ($__phpunit_i = 1; $__phpunit_i < $__phpunit_count; $__phpunit_i++) {

tests/end-to-end/mock-objects/generator/class_nonexistent_method.phpt

@@ -51,7 +51,7 @@ class MockFoo extends Foo implements PHPUnit\Framework\MockObject\MockObjectInte
         $__phpunit_arguments = [];
         $__phpunit_count     = func_num_args();
 
-        if ($__phpunit_count > 0) {
+        if (0 !== null && $__phpunit_count > 0) {
             $__phpunit_arguments_tmp = func_get_args();
 
             for ($__phpunit_i = 0; $__phpunit_i < $__phpunit_count; $__phpunit_i++) {