Skip to content

Commit ad90588

Browse files
Merge branch '11.0'
2 parents c1a8bbd + 88921c9 commit ad90588

File tree

2 files changed

+10
-16
lines changed

2 files changed

+10
-16
lines changed

src/TextUI/TestRunner.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
use function mt_srand;
1313
use PHPUnit\Event;
1414
use PHPUnit\Framework\TestSuite;
15-
use PHPUnit\Runner\Filter\Factory;
1615
use PHPUnit\Runner\ResultCache\ResultCache;
1716
use PHPUnit\Runner\TestSuiteSorter;
1817
use PHPUnit\TextUI\Configuration\Configuration;
@@ -54,7 +53,7 @@ public function run(Configuration $configuration, ResultCache $resultCache, Test
5453
);
5554
}
5655

57-
(new TestSuiteFilterProcessor(new Factory))->process($configuration, $suite);
56+
(new TestSuiteFilterProcessor)->process($configuration, $suite);
5857

5958
Event\Facade::emitter()->testRunnerExecutionStarted(
6059
Event\TestSuite\TestSuiteBuilder::from($suite),

src/TextUI/TestSuiteFilterProcessor.php

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,14 @@
2121
*/
2222
final readonly class TestSuiteFilterProcessor
2323
{
24-
private Factory $filterFactory;
25-
26-
public function __construct(Factory $factory = new Factory)
27-
{
28-
$this->filterFactory = $factory;
29-
}
30-
3124
/**
3225
* @throws Event\RuntimeException
3326
* @throws FilterNotConfiguredException
3427
*/
3528
public function process(Configuration $configuration, TestSuite $suite): void
3629
{
30+
$factory = new Factory;
31+
3732
if (!$configuration->hasFilter() &&
3833
!$configuration->hasGroups() &&
3934
!$configuration->hasExcludeGroups() &&
@@ -44,19 +39,19 @@ public function process(Configuration $configuration, TestSuite $suite): void
4439
}
4540

4641
if ($configuration->hasExcludeGroups()) {
47-
$this->filterFactory->addExcludeGroupFilter(
42+
$factory->addExcludeGroupFilter(
4843
$configuration->excludeGroups(),
4944
);
5045
}
5146

5247
if ($configuration->hasGroups()) {
53-
$this->filterFactory->addIncludeGroupFilter(
48+
$factory->addIncludeGroupFilter(
5449
$configuration->groups(),
5550
);
5651
}
5752

5853
if ($configuration->hasTestsCovering()) {
59-
$this->filterFactory->addIncludeGroupFilter(
54+
$factory->addIncludeGroupFilter(
6055
array_map(
6156
static fn (string $name): string => '__phpunit_covers_' . $name,
6257
$configuration->testsCovering(),
@@ -65,7 +60,7 @@ public function process(Configuration $configuration, TestSuite $suite): void
6560
}
6661

6762
if ($configuration->hasTestsUsing()) {
68-
$this->filterFactory->addIncludeGroupFilter(
63+
$factory->addIncludeGroupFilter(
6964
array_map(
7065
static fn (string $name): string => '__phpunit_uses_' . $name,
7166
$configuration->testsUsing(),
@@ -74,18 +69,18 @@ public function process(Configuration $configuration, TestSuite $suite): void
7469
}
7570

7671
if ($configuration->hasExcludeFilter()) {
77-
$this->filterFactory->addExcludeNameFilter(
72+
$factory->addExcludeNameFilter(
7873
$configuration->excludeFilter(),
7974
);
8075
}
8176

8277
if ($configuration->hasFilter()) {
83-
$this->filterFactory->addIncludeNameFilter(
78+
$factory->addIncludeNameFilter(
8479
$configuration->filter(),
8580
);
8681
}
8782

88-
$suite->injectFilter($this->filterFactory);
83+
$suite->injectFilter($factory);
8984

9085
Event\Facade::emitter()->testSuiteFiltered(
9186
Event\TestSuite\TestSuiteBuilder::from($suite),

0 commit comments

Comments
 (0)