Use stricter comparison

Author: sebastianbergmann

src/TextUI/Output/TestDox/ResultPrinter.php

@@ -264,7 +264,12 @@ private function printThrowable(TestDoxTestResult $test): void
      */
     private function colorizeMessageAndDiff(string $buffer, string $style): array
     {
-        $lines      = $buffer ? array_map('\rtrim', explode(PHP_EOL, $buffer)) : [];
+        $lines = [];
+
+        if ($buffer !== '') {
+            $lines = array_map('\rtrim', explode(PHP_EOL, $buffer));
+        }
+
         $message    = [];
         $diff       = [];
         $insideDiff = false;
@@ -329,11 +334,17 @@ private function formatStackTrace(string $stackTrace): string
 
     private function prefixLines(string $prefix, string $message): string
     {
+        $lines = preg_split('/\r\n|\r|\n/', $message);
+
+        if ($lines === false) {
+            $lines = [];
+        }
+
         return implode(
             PHP_EOL,
             array_map(
-                static fn (string $line) => '   ' . $prefix . ($line ? ' ' . $line : ''),
-                preg_split('/\r\n|\r|\n/', $message) ?: [],
+                static fn (string $line) => '   ' . $prefix . ($line !== '' ? ' ' . $line : ''),
+                $lines,
             ),
         );
     }

src/Util/Filter.php

@@ -42,7 +42,7 @@ public static function stackTraceFromThrowableAsString(Throwable $t, bool $unwra
             $file       = $t->getFile();
             $line       = $t->getLine();
         } else {
-            if ($unwrap && $t->getPrevious()) {
+            if ($unwrap && $t->getPrevious() !== null) {
                 $t = $t->getPrevious();
             }
 

src/Util/Json.php

@@ -77,8 +77,7 @@ public static function canonicalize(string $json): array
      */
     private static function recursiveSort(mixed &$json): void
     {
-        // Nulls, empty arrays, and scalars need no further handling.
-        if (!$json || is_scalar($json)) {
+        if ($json === null || $json === [] || is_scalar($json)) {
             return;
         }
 

src/Util/ThrowableToStringMapper.php

@@ -32,7 +32,7 @@ public static function map(Throwable $t): string
         if ($t instanceof SelfDescribing) {
             $buffer = $t->toString();
 
-            if ($t instanceof ExpectationFailedException && $t->getComparisonFailure()) {
+            if ($t instanceof ExpectationFailedException && $t->getComparisonFailure() !== null) {
                 $buffer .= $t->getComparisonFailure()->getDiff();
             }