Fix CS/WS issues

Author: sebastianbergmann

src/Framework/TestBuilder.php

@@ -95,7 +95,7 @@ private function buildDataProviderTestSuite(string $methodName, string $classNam
         foreach ($data as $_dataName => $_data) {
             $_test = new $className($methodName);
 
-            $_test->setData($_dataName, $_data->getData());
+            $_test->setData($_dataName, $_data->value());
 
             $this->configureTestCase(
                 $_test,

src/Metadata/Api/DataProvider.php

@@ -87,14 +87,14 @@ public function providedData(string $className, string $methodName): ?array
         $testMethodIsNonVariadic      = !$method->isVariadic();
 
         foreach ($data as $key => $providedData) {
-            $value = $providedData->getData();
+            $value = $providedData->value();
 
             if (!is_array($value)) {
                 throw new InvalidDataProviderException(
                     sprintf(
                         'Data set %s provided by %s is invalid, expected array but got %s',
                         $this->formatKey($key),
-                        $providedData->getProviderLabel(),
+                        $providedData->label(),
                         get_debug_type($value),
                     ),
                 );
@@ -117,7 +117,7 @@ public function providedData(string $className, string $methodName): ?array
                     sprintf(
                         'Data set %s provided by %s has more arguments (%d) than the test method accepts (%d)',
                         $this->formatKey($key),
-                        $providedData->getProviderLabel(),
+                        $providedData->label(),
                         count($value),
                         $testMethodNumberOfParameters,
                     ),
@@ -140,7 +140,11 @@ private function dataProvidedByMethods(string $className, string $methodName, Me
     {
         $testMethod    = new Event\Code\ClassMethod($className, $methodName);
         $methodsCalled = [];
-        $result        = [];
+
+        /**
+         * @var array<ProvidedData> $result
+         */
+        $result = [];
 
         foreach ($dataProvider as $_dataProvider) {
             assert($_dataProvider instanceof DataProviderMetadata);
@@ -216,7 +220,7 @@ private function dataProvidedByMethods(string $className, string $methodName, Me
                             sprintf(
                                 'The key "%s" has already been defined by provider %s',
                                 $key,
-                                $result[$key]->getProviderLabel(),
+                                $result[$key]->label(),
                             ),
                         );
                     }
@@ -261,7 +265,7 @@ private function dataProvidedByMetadata(MetadataCollection $testWith): array
                         sprintf(
                             'The key "%s" has already been defined by %s',
                             $key,
-                            $result[$key]->getProviderLabel(),
+                            $result[$key]->label(),
                         ),
                     );
                 }

src/Metadata/Api/ProvidedData.php

@@ -9,21 +9,38 @@
  */
 namespace PHPUnit\Metadata\Api;
 
+/**
+ * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
+ *
+ * @internal This class is not covered by the backward compatibility promise for PHPUnit
+ */
 final readonly class ProvidedData
 {
-    public function __construct(
-        private string $providerLabel,
-        private mixed $data
-    ) {
+    /**
+     * @var non-empty-string
+     */
+    private string $label;
+    private mixed $value;
+
+    /**
+     * @param non-empty-string $label
+     */
+    public function __construct(string $label, mixed $value)
+    {
+        $this->label = $label;
+        $this->value = $value;
     }
 
-    public function getData(): mixed
+    /**
+     * @return non-empty-string
+     */
+    public function label(): string
     {
-        return $this->data;
+        return $this->label;
     }
 
-    public function getProviderLabel(): string
+    public function value(): mixed
     {
-        return $this->providerLabel;
+        return $this->value;
     }
 }

tests/unit/Metadata/Api/DataProviderTest.php

@@ -220,7 +220,7 @@ private function getRawDataFromProvidedData(array $providedData): array
         $raw = [];
 
         foreach ($providedData as $key => $data) {
-            $raw[$key] = $data->getData();
+            $raw[$key] = $data->value();
         }
 
         return $raw;