Don't fiddle with php.ini settings at runtime

Author: staabm

src/Framework/TestCase.php

@@ -26,6 +26,7 @@
 use function getcwd;
 use function implode;
 use function in_array;
+use function ini_get;
 use function ini_set;
 use function is_array;
 use function is_callable;
@@ -83,6 +84,7 @@
 use PHPUnit\Runner\BackedUpEnvironmentVariable;
 use PHPUnit\Runner\DeprecationCollector\Facade as DeprecationCollector;
 use PHPUnit\Runner\HookMethodCollection;
+use PHPUnit\Runner\ShutdownHandler;
 use PHPUnit\TestRunner\TestResult\PassedTests;
 use PHPUnit\TextUI\Configuration\Registry as ConfigurationRegistry;
 use PHPUnit\Util\Exporter;
@@ -1297,7 +1299,10 @@ private function runTest(): mixed
 
         $capture = tmpfile();
         assert($capture !== false);
-        ini_set('display_errors', 1);
+
+        if (ini_get('display_errors') === '0') {
+            ShutdownHandler::setMessage('Fatal error: Premature end of PHP process. Use display_errors=On to see the error message.');
+        }
         $errorLogPrevious = ini_set('error_log', stream_get_meta_data($capture)['uri']);
 
         try {
@@ -1332,6 +1337,7 @@ private function runTest(): mixed
 
             return null;
         } finally {
+            ShutdownHandler::resetMessage();
             fclose($capture);
 
             ini_set('error_log', $errorLogPrevious);

src/Framework/TestRunner/TestRunner.php

@@ -24,6 +24,7 @@
 use PHPUnit\Runner\CodeCoverage;
 use PHPUnit\Runner\ErrorHandler;
 use PHPUnit\Runner\Exception;
+use PHPUnit\Runner\ShutdownHandler;
 use PHPUnit\TextUI\Configuration\Configuration;
 use PHPUnit\TextUI\Configuration\Registry as ConfigurationRegistry;
 use SebastianBergmann\CodeCoverage\Exception as CodeCoverageException;
@@ -83,6 +84,7 @@ public function run(TestCase $test): void
         if ($this->shouldErrorHandlerBeUsed($test)) {
             ErrorHandler::instance()->enable();
         }
+        ShutdownHandler::register();
 
         $collectCodeCoverage = CodeCoverage::instance()->isActive() &&
                                $shouldCodeCoverageBeCollected;

src/Runner/ShutdownHandler.php

@@ -0,0 +1,45 @@
+<?php declare(strict_types=1);
+/*
+ * This file is part of PHPUnit.
+ *
+ * (c) Sebastian Bergmann <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace PHPUnit\Runner;
+
+use function register_shutdown_function;
+
+/**
+ * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
+ *
+ * @internal This class is not covered by the backward compatibility promise for PHPUnit
+ */
+final class ShutdownHandler
+{
+    public static bool $registered = false;
+    private static string $message = '';
+
+    public static function setMessage(string $message): void
+    {
+        self::$message = $message;
+    }
+
+    public static function resetMessage(): void
+    {
+        self::$message = '';
+    }
+
+    public static function register(): void
+    {
+        if (self::$registered) {
+            return;
+        }
+
+        register_shutdown_function(static function (): void
+        {
+            print self::$message;
+        });
+    }
+}

tests/end-to-end/regression/6294-display-errors-off.phpt

@@ -0,0 +1,25 @@
+--TEST--
+Silent failure of PHP fatal errors
+
+https://github.com/sebastianbergmann/phpunit/issues/6294
+--SKIPIF--
+<?php declare(strict_types=1);
+if (version_compare(PHP_VERSION, '8.5.0-dev', '>=')) {
+    print 'skip: PHP < 8.5 is required.';
+}
+--INI--
+display_errors=0
+--FILE--
+<?php declare(strict_types=1);
+$_SERVER['argv'][] = '--do-not-cache-result';
+$_SERVER['argv'][] = '--no-configuration';
+$_SERVER['argv'][] = __DIR__ . '/6294/IssueTest6294.php';
+
+require_once __DIR__ . '/../../bootstrap.php';
+(new PHPUnit\TextUI\Application)->run($_SERVER['argv']);
+--EXPECTF--
+PHPUnit %s by Sebastian Bergmann and contributors.
+
+Runtime: %s
+
+Fatal error: Premature end of PHP process. Use display_errors=On to see the error message.

tests/end-to-end/regression/6294.phpt renamed to tests/end-to-end/regression/6294-display-errors-on.phpt

@@ -8,7 +8,7 @@ if (version_compare(PHP_VERSION, '8.5.0-dev', '>=')) {
     print 'skip: PHP < 8.5 is required.';
 }
 --INI--
-display_errors=0
+display_errors=1
 --FILE--
 <?php declare(strict_types=1);
 $_SERVER['argv'][] = '--do-not-cache-result';