Skip to content

Commit ba650a6

Browse files
Do not overwrite $testMethod variable
1 parent b6406bf commit ba650a6

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

src/Metadata/Api/DataProvider.php

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,11 @@ public function providedData(string $className, string $methodName): ?array
105105
*/
106106
private function dataProvidedByMethods(ReflectionMethod $testMethod, MetadataCollection $dataProvider): array
107107
{
108-
$testMethod = new Event\Code\ClassMethod($testMethod->getDeclaringClass()->getName(), $testMethod->getName());
108+
$testMethodValueObject = new Event\Code\ClassMethod(
109+
$testMethod->getDeclaringClass()->getName(),
110+
$testMethod->getName(),
111+
);
112+
109113
$methodsCalled = [];
110114
$result = [];
111115

@@ -116,7 +120,7 @@ private function dataProvidedByMethods(ReflectionMethod $testMethod, MetadataCol
116120
$dataProviderMethod = new Event\Code\ClassMethod($_dataProvider->className(), $_dataProvider->methodName());
117121

118122
Event\Facade::emitter()->dataProviderMethodCalled(
119-
$testMethod,
123+
$testMethodValueObject,
120124
$dataProviderMethod,
121125
);
122126

@@ -162,7 +166,7 @@ private function dataProvidedByMethods(ReflectionMethod $testMethod, MetadataCol
162166
$data = $className::$methodName();
163167
} catch (Throwable $e) {
164168
Event\Facade::emitter()->dataProviderMethodFinished(
165-
$testMethod,
169+
$testMethodValueObject,
166170
...$methodsCalled,
167171
);
168172

@@ -187,7 +191,7 @@ private function dataProvidedByMethods(ReflectionMethod $testMethod, MetadataCol
187191

188192
if (array_key_exists($key, $result)) {
189193
Event\Facade::emitter()->dataProviderMethodFinished(
190-
$testMethod,
194+
$testMethodValueObject,
191195
...$methodsCalled,
192196
);
193197

@@ -205,7 +209,7 @@ private function dataProvidedByMethods(ReflectionMethod $testMethod, MetadataCol
205209
}
206210

207211
Event\Facade::emitter()->dataProviderMethodFinished(
208-
$testMethod,
212+
$testMethodValueObject,
209213
...$methodsCalled,
210214
);
211215

0 commit comments

Comments
 (0)