Skip to content

Commit bfc644f

Browse files
Revert "Implement LoadedFromFileConfiguration::hasWarnings() and LoadedFromFileConfiguration::warnings()"
This reverts commit f4a5027.
1 parent c3eb501 commit bfc644f

File tree

2 files changed

+1
-24
lines changed

2 files changed

+1
-24
lines changed

src/TextUI/Configuration/Xml/LoadedFromFileConfiguration.php

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -29,20 +29,13 @@
2929
private string $filename;
3030
private ValidationResult $validationResult;
3131

32-
/**
33-
* @psalm-var list<non-empty-string>
34-
*/
35-
private array $warnings;
36-
3732
/**
3833
* @param non-empty-string $filename
39-
* @param list<non-empty-string> $warnings
4034
*/
41-
public function __construct(string $filename, ValidationResult $validationResult, ExtensionBootstrapCollection $extensions, Source $source, CodeCoverage $codeCoverage, Groups $groups, Logging $logging, Php $php, PHPUnit $phpunit, TestSuiteCollection $testSuite, array $warnings)
35+
public function __construct(string $filename, ValidationResult $validationResult, ExtensionBootstrapCollection $extensions, Source $source, CodeCoverage $codeCoverage, Groups $groups, Logging $logging, Php $php, PHPUnit $phpunit, TestSuiteCollection $testSuite)
4236
{
4337
$this->filename = $filename;
4438
$this->validationResult = $validationResult;
45-
$this->warnings = $warnings;
4639

4740
parent::__construct(
4841
$extensions,
@@ -78,17 +71,4 @@ public function wasLoadedFromFile(): bool
7871
{
7972
return true;
8073
}
81-
82-
public function hasWarnings(): bool
83-
{
84-
return !empty($this->warnings);
85-
}
86-
87-
/**
88-
* @psalm-return list<non-empty-string>
89-
*/
90-
public function warnings(): array
91-
{
92-
return $this->warnings;
93-
}
9474
}

src/TextUI/Configuration/Xml/Loader.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,6 @@ public function load(string $filename): LoadedFromFileConfiguration
114114

115115
assert($configurationFileRealpath !== false && $configurationFileRealpath !== '');
116116

117-
$warnings = [];
118-
119117
return new LoadedFromFileConfiguration(
120118
$configurationFileRealpath,
121119
(new Validator)->validate($document, $xsdFilename),
@@ -127,7 +125,6 @@ public function load(string $filename): LoadedFromFileConfiguration
127125
$this->php($configurationFileRealpath, $xpath),
128126
$this->phpunit($configurationFileRealpath, $document),
129127
$this->testSuite($configurationFileRealpath, $xpath),
130-
$warnings,
131128
);
132129
}
133130

0 commit comments

Comments
 (0)