Skip to content

Commit f4a5027

Browse files
Implement LoadedFromFileConfiguration::hasWarnings() and LoadedFromFileConfiguration::warnings()
1 parent 097acaf commit f4a5027

File tree

2 files changed

+26
-1
lines changed

2 files changed

+26
-1
lines changed

src/TextUI/Configuration/Xml/LoadedFromFileConfiguration.php

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,19 @@
2626
private string $filename;
2727
private ValidationResult $validationResult;
2828

29-
public function __construct(string $filename, ValidationResult $validationResult, ExtensionBootstrapCollection $extensions, Source $source, CodeCoverage $codeCoverage, Groups $groups, Logging $logging, Php $php, PHPUnit $phpunit, TestSuiteCollection $testSuite)
29+
/**
30+
* @psalm-var list<non-empty-string>
31+
*/
32+
private array $warnings;
33+
34+
/**
35+
* @param list<non-empty-string> $warnings
36+
*/
37+
public function __construct(string $filename, ValidationResult $validationResult, ExtensionBootstrapCollection $extensions, Source $source, CodeCoverage $codeCoverage, Groups $groups, Logging $logging, Php $php, PHPUnit $phpunit, TestSuiteCollection $testSuite, array $warnings)
3038
{
3139
$this->filename = $filename;
3240
$this->validationResult = $validationResult;
41+
$this->warnings = $warnings;
3342

3443
parent::__construct(
3544
$extensions,
@@ -62,4 +71,17 @@ public function wasLoadedFromFile(): bool
6271
{
6372
return true;
6473
}
74+
75+
public function hasWarnings(): bool
76+
{
77+
return !empty($this->warnings);
78+
}
79+
80+
/**
81+
* @psalm-return list<non-empty-string>
82+
*/
83+
public function warnings(): array
84+
{
85+
return $this->warnings;
86+
}
6587
}

src/TextUI/Configuration/Xml/Loader.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,8 @@ public function load(string $filename): LoadedFromFileConfiguration
108108

109109
$configurationFileRealpath = realpath($filename);
110110

111+
$warnings = [];
112+
111113
return new LoadedFromFileConfiguration(
112114
$configurationFileRealpath,
113115
(new Validator)->validate($document, $xsdFilename),
@@ -119,6 +121,7 @@ public function load(string $filename): LoadedFromFileConfiguration
119121
$this->php($configurationFileRealpath, $xpath),
120122
$this->phpunit($configurationFileRealpath, $document),
121123
$this->testSuite($configurationFileRealpath, $xpath),
124+
$warnings,
122125
);
123126
}
124127

0 commit comments

Comments
 (0)