Closes #5652

Six people, see below, spent more than two hours, to research this issue. They eventually gave up and decided to not raise an exception and instead return a Duration object that represents 0 seconds and 0 nanoseconds.

Co-authored-by: Sebastian Bergmann <[email protected]>
Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]>
Co-authored-by: Sebastian Heuer <[email protected]>
Co-authored-by: Fabian Blechschmidt <[email protected]>
Co-authored-by: Frank Sons <[email protected]>

Author: 6 people

.psalm/baseline.xml

@@ -110,6 +110,7 @@
   <file src="src/Event/Value/Telemetry/HRTime.php">
     <ImpureMethodCall>
       <code><![CDATA[fromSecondsAndNanoseconds]]></code>
+      <code><![CDATA[fromSecondsAndNanoseconds]]></code>
     </ImpureMethodCall>
   </file>
   <file src="src/Event/Value/Telemetry/MemoryUsage.php">

ChangeLog-10.5.md

@@ -2,6 +2,12 @@
 
 All notable changes of the PHPUnit 10.5 release series are documented in this file using the [Keep a CHANGELOG](https://keepachangelog.com/) principles.
 
+## [10.5.12] - 2024-MM-DD
+
+### Fixed
+
+* [#5652](https://github.com/sebastianbergmann/phpunit/issues/5652): `HRTime::duration()` throws `InvalidArgumentException`
+
 ## [10.5.11] - 2024-02-25
 
 ### Fixed
@@ -125,6 +131,7 @@ All notable changes of the PHPUnit 10.5 release series are documented in this fi
 
 * [#5563](https://github.com/sebastianbergmann/phpunit/issues/5563): `createMockForIntersectionOfInterfaces()` does not automatically register mock object for expectation verification
 
+[10.5.12]: https://github.com/sebastianbergmann/phpunit/compare/10.5.11...10.5
 [10.5.11]: https://github.com/sebastianbergmann/phpunit/compare/10.5.10...10.5.11
 [10.5.10]: https://github.com/sebastianbergmann/phpunit/compare/10.5.9...10.5.10
 [10.5.9]: https://github.com/sebastianbergmann/phpunit/compare/10.5.8...10.5.9

src/Event/Value/Telemetry/HRTime.php

@@ -56,9 +56,6 @@ public function nanoseconds(): int
         return $this->nanoseconds;
     }
 
-    /**
-     * @throws InvalidArgumentException
-     */
     public function duration(self $start): Duration
     {
         $seconds     = $this->seconds - $start->seconds();
@@ -71,7 +68,7 @@ public function duration(self $start): Duration
         }
 
         if ($seconds < 0) {
-            throw new InvalidArgumentException('Start needs to be smaller.');
+            return Duration::fromSecondsAndNanoseconds(0, 0);
         }
 
         return Duration::fromSecondsAndNanoseconds(

tests/unit/Event/Value/Telemetry/HRTimeTest.php

@@ -124,7 +124,7 @@ public function testFromSecondsAndNanosecondsReturnsHRTime(): void
     }
 
     #[DataProvider('provideStartGreaterThanEnd')]
-    public function testDurationRejectsStartGreaterThanEnd(int $startSeconds, int $startNanoseconds, int $endSeconds, int $endNanoseconds): void
+    public function testDurationIgnoresStartGreaterThanEnd(int $startSeconds, int $startNanoseconds, int $endSeconds, int $endNanoseconds): void
     {
         $start = HRTime::fromSecondsAndNanoseconds(
             $startSeconds,
@@ -136,10 +136,10 @@ public function testDurationRejectsStartGreaterThanEnd(int $startSeconds, int $s
             $endNanoseconds,
         );
 
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('Start needs to be smaller.');
+        $duration = $end->duration($start);
 
-        $end->duration($start);
+        $this->assertSame(0, $duration->seconds());
+        $this->assertSame(0, $duration->nanoseconds());
     }
 
     #[DataProvider('provideStartEndAndDuration')]