PHPUnit 12.2.0 breaks Rector test case

[TomasVotruba]

I'm coming with a humble request to fix Rector test case. This commit in 12.2.0 preloads 3 packages that now trigger nikic/php-parser autoload: dea8cff

• SebastianBergmann\CodeCoverage
• SebastianBergmann\Complexity
• SebastianBergmann\LinesOfCode

Currently we patch php-parser to allow Rector rules to use StmtsAware and NodeTraverser cache. Because of this autoload in here, if someone runs PHPUnit 12 Rector test case in their code, it crashes because we're preloading our version of php-parser

Any chance to remove or disable this? At the moment anyone running Rector tests on PHPUnit 12 can't. Thanks for any help

[sebastianbergmann]

I understand where you’re coming from, but I think your use case is outside the scope of this project.

The best long-term solution would be to get the changes you need integrated into PHP-Parser itself, rather than maintaining a custom patch. I realize that may sound a bit ironic coming from me, given that I’ve had to work around a PHP-Parser-related issue in PHPUnit’s PHAR build process as well (https://github.com/sebastianbergmann/phpunit/blob/12.4.0/build.xml#L295-L305).

[TomasVotruba]

Agreed it's better to solve on php-parser and it started initially there.
But this change has not been merged past 3 years nikic/PHP-Parser#836

Any chance to allow this preloading tu turn off for PHPUnit 12? Now any community tests running on PHPUnit 12 is broken

[sebastianbergmann]

Any chance to allow this preloading tu turn off for PHPUnit 12?

I do not think so.

Now any community tests running on PHPUnit 12 is broken.

I doubt that any projects other than Rector (or projects that patch their dependencies) would be affected by this. If that were the case, I'm sure I would have heard about it by now.

[TomasVotruba]

Now any community tests running on PHPUnit 12 is broken.

I mean Rector community tests. Any tool/project that uses Rector and writes custom Rector tests has is failing.

[samsonasik]

@sebastianbergmann imo, the PHPUnit 12 custom bootstrap is not works as it should be, as the vendor classmap is always loaded too early, so we can't just use our own autoload/preload, eg, manual creation:

         bootstrap="tests/utils/bootstrap.php"

and it contains early our own autoload:

require_once 'vendor/rector/rector/preload.php';
require_once 'vendor/autoload.php';

this can't work on PHPUnit 12, because it already loaded too early.

I think it would be great if there is a way to make this force optional.

[brendt]

Hi folks, I wanted to check whether there's a workaround for this issue already documented somewhere? We're using phpunit/phpunit:12.4.1 and rector/rector:2.2.2 atm (https://github.com/tempestphp/tempest-framework/actions/runs/18418288049/job/52504171942?pr=1632)

Any pointers on how to deal with this issue from a project's pov would be welcome :)

[samsonasik]

@brendt we are at rector tried to handle automatically at rector 2.2 2, but the possible last resort is using composer -> files :)

https://getrector.com/documentation/troubleshooting-preload

Phpunit 12 too early autoload vendor/autoload make custom bootstrap not works as it should be :)

[TomasVotruba]

@brendt Hey, we have an monitoring issue here: rectorphp/rector#9416

And repository for failing reproducers here: https://github.com/rectorphp/rector-compat-tests, if you can add your minimal isolated case, it would speed up the fix

[brendt]

Well for now (since it's early morning for me and I didn't want to spend a lot of time on it right now), we fixed versions to:

"phpunit/phpunit": "12.4.0"
"rector/rector": "2.2.1"

As a temporary fix. Just leaving it here in case anyone runs in the same issue and wants a quickfix.