Fix expectUserDeprecationMessage*() failure when test is run in separate process
#6283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mondrake
changed the title
expectUserDeprecationMessage*() failure when test is run in separate process
mondrake
changed the title
expectUserDeprecationMessage*() failure when test is run in separate processexpectUserDeprecationMessage*() failure when test is run in separate process
mondrake
changed the title
expectUserDeprecationMessage*() failure when test is run in separate processexpectUserDeprecationMessage*() failure when test is run in separate process
staabm
reviewed
Aug 6, 2025
| @@ -0,0 +1,38 @@ | |||
| --TEST-- | |||
There was a problem hiding this comment.
could we have a better test name then 6102-1 and 6102-2. something which reflects the difference of the 2 tests
There was a problem hiding this comment.
Would 6102-cli-argument and 6102-class-attribute be more relevant?
There was a problem hiding this comment.
I would go with something like
6102-process-isolated-arg
6102-separate-processes-attribute
There was a problem hiding this comment.
How about 6102-process-isolation-via-attribute.phpt and 6102-process-isolation-via-cli-option.phpt?
There was a problem hiding this comment.
afk at the moment, will look into it when possible if noone beats me at it
|
Cherry-picked into |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Aug 21, 2025
…ionMessage() method (xabbuh) This PR was merged into the 7.4 branch. Discussion ---------- [HttpFoundation] use PHPUnit's native expectUserDeprecationMessage() method | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT In #58370 I rewrote the tests in `NativeSessionStorageTest` to work around a bug in PHPUnit that didn't allow to have assertions about deprecations triggered in tests that were run in separate processes. Thanks to sebastianbergmann/phpunit#6283 (available in e.g. PHPUnit 12.3.5+) we don't need this workaround anymore. Commits ------- c7b14f8 use PHPUnit's native expectUserDeprecationMessage() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6102.