Skip to content

PHPT: Trigger runner warning on fatal-error in SKIPIF #6312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

PHPT: Trigger runner warning on fatal-error in SKIPIF #6312

wants to merge 6 commits into from
+99 −0

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Aug 12, 2025 •
edited
Loading

closes #6311
closes #5991

@staabm staabm marked this pull request as ready for review August 12, 2025 14:26
@staabm
Copy link
Contributor Author

staabm commented Aug 12, 2025

I will do a separate PR to do similar checks for other parts of PHPT in case fatal/parse-errors are not yet reported

@staabm staabm closed this Aug 12, 2025
@staabm staabm reopened this Aug 12, 2025
@sebastianbergmann sebastianbergmann added type/enhancement A new idea that should be implemented feature/phpt End-to-end tests in PHPT format labels Aug 13, 2025
@sebastianbergmann
Copy link
Owner

Cherry-picked into 12.3 and merged to main from there.

@staabm staabm deleted the errskip branch August 13, 2025 05:23
This was referenced Aug 13, 2025
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature/phpt End-to-end tests in PHPT format type/enhancement A new idea that should be implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHPT: require with invalid path not reported PHPT: Parse Error in SKIPIF not reported
2 participants
@staabm @sebastianbergmann