[Fix] limits: Darwin's limits were too high, reduced

Author: sebastien

src/py/extra/utils/limits.py

@@ -1,6 +1,6 @@
 from typing import NamedTuple, Annotated
-import resource
 from enum import Enum
+import resource
 
 
 class LimitType(Enum):
@@ -11,6 +11,16 @@ class LimitType(Enum):
 	Processes = resource.RLIMIT_NPROC
 
 
+REASONABLE_LIMITS: dict[LimitType, int] = {
+	LimitType.Files: 10
+	* 10240,  # Minimum recommended for production servers handling multiple connections
+	LimitType.Cores: 0,  # Disable core dumps to save disk space in production
+	LimitType.CPU: 3600,  # 1 hour soft limit to prevent runaway processes
+	LimitType.FileSize: int(1e12),  # 1 TB to cap large file creations like logs
+	LimitType.Processes: 4096,  # Supports multiple workers without risking overload
+}
+
+
 class Limit(NamedTuple):
 	type: LimitType
 	soft: int
@@ -29,10 +39,17 @@ def limit(scope: LimitType) -> Limit:
 	return Limit(scope, *resource.getrlimit(scope.value))
 
 
-def unlimit(scope: LimitType, ratio: float = 1.0) -> int | bool:
+def unlimit(
+	scope: LimitType, ratio: float = 1.0, *, maximum: int | None = 0
+) -> int | bool:
 	lm = limit(scope)
 	try:
 		target = int(lm.soft + ratio * (lm.hard - lm.soft))
+		# We apply reasonable limits, as for instance Darwin has really high
+		# limits that will lead to OverflowErrors.
+		maximum = REASONABLE_LIMITS.get(scope) if maximum == 0 else maximum
+		if maximum:
+			target = min(maximum, target)
 		resource.setrlimit(scope.value, (target, lm.hard))
 		return target
 	except ValueError: