Fix build warnings (#206)

sebastienros · web-flow · commit c8719da255c5 · 2021-11-02T16:37:17.000-07:00
diff --git a/.gitattributes b/.gitattributes
@@ -0,0 +1,2 @@
+# Auto detect text files and perform LF normalization
+* text=auto
diff --git a/samples/Esprima.Sample/Program.cs b/samples/Esprima.Sample/Program.cs
@@ -1,8 +1,8 @@
 ﻿using System;
 using System.Collections.Generic;
 using System.IO;
-using Newtonsoft.Json;
 using Esprima.Utils;
+using Newtonsoft.Json;
 
 namespace Esprima.Sample
 {
diff --git a/src/Esprima/Ast/ArrayExpression.cs b/src/Esprima/Ast/ArrayExpression.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/AssignmentExpression.cs b/src/Esprima/Ast/AssignmentExpression.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 using static Esprima.EsprimaExceptionHelper;
 
 namespace Esprima.Ast
diff --git a/src/Esprima/Ast/AwaitExpression.cs b/src/Esprima/Ast/AwaitExpression.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/BinaryExpression.cs b/src/Esprima/Ast/BinaryExpression.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 using static Esprima.EsprimaExceptionHelper;
 
 namespace Esprima.Ast
diff --git a/src/Esprima/Ast/BlockStatement.cs b/src/Esprima/Ast/BlockStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/BreakStatement.cs b/src/Esprima/Ast/BreakStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/CallExpression.cs b/src/Esprima/Ast/CallExpression.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/CatchClause.cs b/src/Esprima/Ast/CatchClause.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/ChainExpression.cs b/src/Esprima/Ast/ChainExpression.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/ClassElement.cs b/src/Esprima/Ast/ClassElement.cs
@@ -1,4 +1,4 @@
-#nullable disable
+﻿#nullable disable
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/ConditionalExpression.cs b/src/Esprima/Ast/ConditionalExpression.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/ContinueStatement.cs b/src/Esprima/Ast/ContinueStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/DebuggerStatement.cs b/src/Esprima/Ast/DebuggerStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/DoWhileStatement.cs b/src/Esprima/Ast/DoWhileStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/EmptyStatement.cs b/src/Esprima/Ast/EmptyStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/Expression.cs b/src/Esprima/Ast/Expression.cs
@@ -1,4 +1,4 @@
-namespace Esprima.Ast
+﻿namespace Esprima.Ast
 {
     /// <summary>
     /// A JavaScript expression. 
diff --git a/src/Esprima/Ast/ExpressionStatement.cs b/src/Esprima/Ast/ExpressionStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/ForInStatement.cs b/src/Esprima/Ast/ForInStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/ForStatement.cs b/src/Esprima/Ast/ForStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/FunctionDeclaration.cs b/src/Esprima/Ast/FunctionDeclaration.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/FunctionExpression.cs b/src/Esprima/Ast/FunctionExpression.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/GenericChildNodeYield.cs b/src/Esprima/Ast/GenericChildNodeYield.cs
@@ -1,4 +1,4 @@
-using System.Runtime.CompilerServices;
+﻿using System.Runtime.CompilerServices;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/Identifier.cs b/src/Esprima/Ast/Identifier.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/IfStatement.cs b/src/Esprima/Ast/IfStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/Import.cs b/src/Esprima/Ast/Import.cs
@@ -4,7 +4,7 @@ namespace Esprima.Ast
 {
     public sealed class Import : Expression
     {
-        public readonly Expression Source;
+        public readonly Expression? Source;
 
         public Import() : base(Nodes.Import)
         {
diff --git a/src/Esprima/Ast/LabeledStatement.cs b/src/Esprima/Ast/LabeledStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/Literal.cs b/src/Esprima/Ast/Literal.cs
@@ -1,4 +1,4 @@
-using System.Text.RegularExpressions;
+﻿using System.Text.RegularExpressions;
 using Esprima.Utils;
 
 namespace Esprima.Ast
diff --git a/src/Esprima/Ast/MemberExpression.cs b/src/Esprima/Ast/MemberExpression.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/Module.cs b/src/Esprima/Ast/Module.cs
@@ -1,4 +1,4 @@
-namespace Esprima.Ast
+﻿namespace Esprima.Ast
 {
     public sealed class Module : Program
     {
diff --git a/src/Esprima/Ast/NewExpression.cs b/src/Esprima/Ast/NewExpression.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/NodeExtensions.cs b/src/Esprima/Ast/NodeExtensions.cs
@@ -1,7 +1,7 @@
 ﻿using System.Collections.Generic;
 using System.Diagnostics;
-using NodeSysList = System.Collections.Generic.List<Esprima.Ast.Node>;
 using static Esprima.EsprimaExceptionHelper;
+using NodeSysList = System.Collections.Generic.List<Esprima.Ast.Node>;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/ObjectExpression.cs b/src/Esprima/Ast/ObjectExpression.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/Program.cs b/src/Esprima/Ast/Program.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/Property.cs b/src/Esprima/Ast/Property.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/PropertyKind.cs b/src/Esprima/Ast/PropertyKind.cs
@@ -1,4 +1,4 @@
-using System;
+﻿using System;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/ReturnStatement.cs b/src/Esprima/Ast/ReturnStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/Script.cs b/src/Esprima/Ast/Script.cs
@@ -1,4 +1,4 @@
-namespace Esprima.Ast
+﻿namespace Esprima.Ast
 {
     public sealed class Script : Program
     {
diff --git a/src/Esprima/Ast/SequenceExpression.cs b/src/Esprima/Ast/SequenceExpression.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/Statement.cs b/src/Esprima/Ast/Statement.cs
@@ -1,4 +1,4 @@
-namespace Esprima.Ast
+﻿namespace Esprima.Ast
 {
     public abstract class Statement : StatementListItem
     {
diff --git a/src/Esprima/Ast/SwitchCase.cs b/src/Esprima/Ast/SwitchCase.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/SwitchStatement.cs b/src/Esprima/Ast/SwitchStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/ThisExpression.cs b/src/Esprima/Ast/ThisExpression.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/ThrowStatement.cs b/src/Esprima/Ast/ThrowStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/TryStatement.cs b/src/Esprima/Ast/TryStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/UnaryExpression.cs b/src/Esprima/Ast/UnaryExpression.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 using static Esprima.EsprimaExceptionHelper;
 
 namespace Esprima.Ast
diff --git a/src/Esprima/Ast/UpdateExpression.cs b/src/Esprima/Ast/UpdateExpression.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/VariableDeclaration.cs b/src/Esprima/Ast/VariableDeclaration.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/VariableDeclarationKind.cs b/src/Esprima/Ast/VariableDeclarationKind.cs
@@ -1,4 +1,4 @@
-namespace Esprima.Ast
+﻿namespace Esprima.Ast
 {
     public enum VariableDeclarationKind
     {
diff --git a/src/Esprima/Ast/VariableDeclarator.cs b/src/Esprima/Ast/VariableDeclarator.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/WhileStatement.cs b/src/Esprima/Ast/WhileStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/Ast/WithStatement.cs b/src/Esprima/Ast/WithStatement.cs
@@ -1,4 +1,4 @@
-using Esprima.Utils;
+﻿using Esprima.Utils;
 
 namespace Esprima.Ast
 {
diff --git a/src/Esprima/ErrorHandler.cs b/src/Esprima/ErrorHandler.cs
@@ -1,4 +1,4 @@
-namespace Esprima
+﻿namespace Esprima
 {
     /// <summary>
     /// Default error handling logic for Esprima.
diff --git a/src/Esprima/EsprimaExceptionHelper.cs b/src/Esprima/EsprimaExceptionHelper.cs
@@ -1,4 +1,4 @@
-using System;
+﻿using System;
 
 namespace Esprima
 {
diff --git a/src/Esprima/Exception.cs b/src/Esprima/Exception.cs
@@ -1,4 +1,4 @@
-namespace Esprima
+﻿namespace Esprima
 {
     using System;
 
diff --git a/src/Esprima/JavascriptParser.cs b/src/Esprima/JavascriptParser.cs
@@ -71,7 +71,7 @@ public Context()
         private bool _hasLineTerminator;
         private readonly Action<Node>? _action;
 
-        private List<Token> _tokens = new();
+        private readonly List<Token> _tokens = new();
 
         /// <summary>
         /// Returns the list of tokens that were parsed.
diff --git a/src/Esprima/Marker.cs b/src/Esprima/Marker.cs
@@ -1,4 +1,4 @@
-namespace Esprima
+﻿namespace Esprima
 {
     internal class Marker
     {
diff --git a/src/Esprima/Utils/AstVisitor.cs b/src/Esprima/Utils/AstVisitor.cs
diff --git a/src/Esprima/Utils/EnumMemberAttribute.cs b/src/Esprima/Utils/EnumMemberAttribute.cs
diff --git a/src/Esprima/Utils/JsonTextWriter.cs b/src/Esprima/Utils/JsonTextWriter.cs
diff --git a/test/Esprima.Tests/AstVisitorEventSourceTests.cs b/test/Esprima.Tests/AstVisitorEventSourceTests.cs
diff --git a/test/Esprima.Tests/Fixtures.cs b/test/Esprima.Tests/Fixtures.cs
diff --git a/test/Esprima.Tests/RegExpTests.cs b/test/Esprima.Tests/RegExpTests.cs
diff --git a/test/Esprima.Tests/ScannerTests.cs b/test/Esprima.Tests/ScannerTests.cs
diff --git a/test/Esprima.Tests/StrictModeTests.cs b/test/Esprima.Tests/StrictModeTests.cs

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+# Auto detect text files and perform LF normalization`
	`2`	`+* text=auto`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`	`1`	`using System;`
`2`	`2`	`using System.Collections.Generic;`
`3`	`3`	`using System.IO;`
`4`		`-using Newtonsoft.Json;`
`5`	`4`	`using Esprima.Utils;`
	`5`	`+using Newtonsoft.Json;`
`6`	`6`
`7`	`7`	`namespace Esprima.Sample`
`8`	`8`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-using Esprima.Utils;`
	`1`	`+using Esprima.Utils;`
`2`	`2`
`3`	`3`	`namespace Esprima.Ast`
`4`	`4`	`{`