ES2020 BigInt (#1027)

Co-authored-by: Sébastien Ros <[email protected]>

Author: lahma

Jint.Repl/Program.cs

@@ -66,7 +66,7 @@ private static void Main(string[] args)
                 try
                 {
                     var result = engine.Evaluate(input, parserOptions);
-                    if (!result.IsNull() && !result.IsUndefined())
+                    if (!result.IsPrimitive() && result is not IPrimitiveInstance)
                     {
                         var serializer = new JsonSerializer(engine);
                         var str = serializer.Serialize(result, Undefined.Instance, "  ");

Jint.Tests.Test262/BuiltIns/BigIntTests.cs

@@ -0,0 +1,15 @@
+using Xunit;
+
+namespace Jint.Tests.Test262.BuiltIns
+{
+    public class BigIntTests : Test262Test
+    {
+        [Theory(DisplayName = "built-ins\\BigInt")]
+        [MemberData(nameof(SourceFiles), "built-ins\\BigInt", false)]
+        [MemberData(nameof(SourceFiles), "built-ins\\BigInt", true, Skip = "Skipped")]
+        protected void RunTest(SourceFile sourceFile)
+        {
+            RunTestInternal(sourceFile);
+        }
+    }
+}

Jint.Tests.Test262/Test262Test.cs

@@ -73,6 +73,7 @@ static Test262Test()
                 "detachArrayBuffer.js",
                 "byteConversionValues.js",
                 "hidden-constructors.js",
+                "testBigIntTypedArray.js"
             };
 
             Sources = new Dictionary<string, Script>(files.Length);
@@ -174,7 +175,7 @@ protected void RunTestCode(string fileName, string code, bool strict)
 
             if (!negative && !string.IsNullOrWhiteSpace(lastError))
             {
-                throw new XunitException(lastError);
+                throw new XunitException($"{Environment.NewLine}{fileName}{Environment.NewLine}{Environment.NewLine}{lastError}");
             }
         }
 
@@ -242,10 +243,6 @@ public static IEnumerable<object[]> SourceFiles(string pathPrefix, bool skipped)
                                 skip = true;
                                 reason = "tail-calls not implemented";
                                 break;
-                            case "BigInt":
-                                skip = true;
-                                reason = "BigInt not implemented";
-                                break;
                             case "generators":
                                 skip = true;
                                 reason = "generators not implemented";

Jint.Tests.Test262/test/built-ins/BigInt/asIntN/bigint-tobigint-errors.js

@@ -9,6 +9,15 @@ info: |
   2. Let bigint ? ToBigInt(bigint).
 features: [BigInt, computed-property-names, Symbol, Symbol.toPrimitive]
 ---*/
+assert.sameValue(typeof BigInt, 'function');
+assert.sameValue(typeof BigInt.asIntN, 'function');
+
+assert.throws(TypeError, function () {
+  BigInt.asIntN();
+}, "ToBigInt: no argument => undefined => TypeError");
+assert.throws(TypeError, function () {
+  BigInt.asIntN(0);
+}, "ToBigInt: no argument => undefined => TypeError");
 
 assert.throws(TypeError, function() {
   BigInt.asIntN(0, undefined);

Jint.Tests.Test262/test/built-ins/BigInt/asIntN/bigint-tobigint-toprimitive.js

@@ -9,7 +9,8 @@ info: |
   2. Let bigint ? ToBigInt(bigint).
 features: [BigInt, computed-property-names, Symbol, Symbol.toPrimitive]
 ---*/
-
+assert.sameValue(typeof BigInt, 'function');
+assert.sameValue(typeof BigInt.asIntN, 'function');
 function err() {
   throw new Test262Error();
 }

Jint.Tests.Test262/test/built-ins/BigInt/asIntN/bits-toindex-errors.js

@@ -9,6 +9,8 @@ info: |
   1. Let bits be ? ToIndex(bits).
 features: [BigInt, computed-property-names, Symbol, Symbol.toPrimitive]
 ---*/
+assert.sameValue(typeof BigInt, 'function');
+assert.sameValue(typeof BigInt.asIntN, 'function');
 
 assert.throws(RangeError, function() {
   BigInt.asIntN(-1, 0n);

Jint.Tests.Test262/test/built-ins/BigInt/asIntN/bits-toindex-toprimitive.js

@@ -9,6 +9,8 @@ info: |
   1. Let bits be ? ToIndex(bits).
 features: [BigInt, computed-property-names, Symbol, Symbol.toPrimitive]
 ---*/
+assert.sameValue(typeof BigInt, 'function');
+assert.sameValue(typeof BigInt.asIntN, 'function');
 
 function err() {
   throw new Test262Error();

Jint.Tests.Test262/test/built-ins/BigInt/asIntN/not-a-constructor.js

@@ -0,0 +1,26 @@
+// Copyright (C) 2020 Rick Waldron. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-ecmascript-standard-built-in-objects
+description: >
+  BigInt.asIntN does not implement [[Construct]], is not new-able
+info: |
+  ECMAScript Function Objects
+
+  Built-in function objects that are not identified as constructors do not
+  implement the [[Construct]] internal method unless otherwise specified in
+  the description of a particular function.
+
+  sec-evaluatenew
+
+  ...
+  7. If IsConstructor(constructor) is false, throw a TypeError exception.
+  ...
+includes: [isConstructor.js]
+features: [Reflect.construct, BigInt, arrow-function]
+---*/
+assert.sameValue(isConstructor(BigInt.asIntN), false, 'isConstructor(BigInt.asIntN) must return false');
+
+assert.throws(TypeError, () => {
+  new BigInt.asIntN(64, 1n);
+}, '`new BigInt.asIntN(64, 1n)` throws TypeError');

Jint.Tests.Test262/test/built-ins/BigInt/asUintN/bigint-tobigint-errors.js

@@ -9,6 +9,15 @@ info: |
   2. Let bigint ? ToBigInt(bigint).
 features: [BigInt, computed-property-names, Symbol, Symbol.toPrimitive]
 ---*/
+assert.sameValue(typeof BigInt, 'function');
+assert.sameValue(typeof BigInt.asUintN, 'function');
+
+assert.throws(TypeError, function () {
+  BigInt.asUintN();
+}, "ToBigInt: no argument => undefined => TypeError");
+assert.throws(TypeError, function () {
+  BigInt.asUintN(0);
+}, "ToBigInt: no argument => undefined => TypeError");
 
 assert.throws(TypeError, function() {
   BigInt.asUintN(0, undefined);

Jint.Tests.Test262/test/built-ins/BigInt/asUintN/bigint-tobigint-toprimitive.js

@@ -9,6 +9,8 @@ info: |
   2. Let bigint ? ToBigInt(bigint).
 features: [BigInt, computed-property-names, Symbol, Symbol.toPrimitive]
 ---*/
+assert.sameValue(typeof BigInt, 'function');
+assert.sameValue(typeof BigInt.asUintN, 'function');
 
 function err() {
   throw new Test262Error();