-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomers
Description
The current version of the HotkeylessAHK performance test does not work with the register functionality yet. This causes the pendingResult in the server.js to never be resolved, ultimately causing a timeout and no accurate measurements (or no measurements at all). However, as this only affects benchmarking and not the actual functionality and also, the numbers in the README are accurate, fixing these issues has currently no priority.
Workaround, if you really want to benchmark: Add these two lines instead of line 46 in server.js:
- console.error(`Function '${functionName}' not found in any class.`);
+ this.pendingResult.send(command);
+ this.pendingResult = null;Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomers