Skip to content

Commit bf3358f

Browse files
committed
Added comment
1 parent 51cbc16 commit bf3358f

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

src/Network/JsonRpc/Types.hs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,8 @@ instance A.ToJSON Response where
125125
, either ("error" .=) ("result" .=) result
126126
, idKey .= i]
127127

128+
-- IdNumber cannot directly reference the type stored in A.Number,
129+
-- since it changes between aeson-0.6 and 0.7.
128130
data Id = IdString A.Value | IdNumber A.Value | IdNull
129131

130132
instance A.FromJSON Id where

tests/TestTypes.hs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ instance A.FromJSON TestResponse where
5151
((Left <$> obj .: "error") <|> (Right <$> obj .: "result"))
5252
parseJSON _ = empty
5353

54+
-- IdNumber cannot directly reference the type stored in A.Number,
55+
-- since it changes between aeson-0.6 and 0.7.
5456
data TestId = IdString A.Value | IdNumber A.Value | IdNull
5557
deriving (Eq, Show)
5658

0 commit comments

Comments
 (0)