Skip to content

Commit 9c91e1e

Browse files
committed
TestRuleAddAndLoad: don't use magic number
Rather than using some magic number 28 (which corresponds to ENOSPC), let's use syscall.ENOSPC and convert it to int16 when needed. Fixes: 9006a28 Reported-by: Rodrigo Campos <[email protected]> Signed-off-by: Kir Kolyshkin <[email protected]>
1 parent 8570da4 commit 9c91e1e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

seccomp_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -590,12 +590,12 @@ func subprocessRuleAddAndLoad(t *testing.T) {
590590
}
591591
defer filter1.Release()
592592

593-
const expErr = 28 // ENOSPC, but can be anything not usually returned by listen(2).
593+
const expErr = syscall.ENOSPC // Can be anything not usually returned by listen(2).
594594
call, err := GetSyscallFromName("listen")
595595
if err != nil {
596596
t.Errorf("Error getting syscall number of listen: %s", err)
597597
}
598-
err = filter1.AddRule(call, ActErrno.SetReturnCode(expErr))
598+
err = filter1.AddRule(call, ActErrno.SetReturnCode(int16(expErr)))
599599
if err != nil {
600600
t.Errorf("Error adding rule to restrict syscall: %s", err)
601601
}
@@ -641,8 +641,8 @@ func subprocessRuleAddAndLoad(t *testing.T) {
641641
}
642642

643643
// Try making a simple syscall which should return an error.
644-
if err := syscall.Listen(0, 0); err != syscall.Errno(expErr) {
645-
t.Errorf("Syscall listen: want %v, got %v", syscall.Errno(expErr), err)
644+
if err := syscall.Listen(0, 0); err != expErr {
645+
t.Errorf("Syscall listen: want %v, got %v", expErr, err)
646646
}
647647

648648
// Try making a Geteuid syscall that should normally succeed

0 commit comments

Comments
 (0)