Fix critical bit set

dmaciejak · web-flow · commit 9cb9d0230a61 · 2025-01-27T10:28:16.000-05:00
Critical bit is set on the MSB
diff --git a/scapy/contrib/ikev2.py b/scapy/contrib/ikev2.py
@@ -568,7 +568,7 @@ class IKEv2_Payload(_IKEv2_Packet):
     name = "IKEv2 Payload"
     fields_desc = [
         ByteEnumField("next_payload", None, IKEv2PayloadTypes),
-        FlagsField("flags", 0, 8, ["critical"]),
+        FlagsField("flags", 0, 8, {0x80: "critical"}),
         ShortField("length", None),
         XStrLenField("load", "", length_from=lambda pkt: pkt.length - 4),
     ]

Original file line number	Diff line number	Diff line change
`@@ -568,7 +568,7 @@ class IKEv2_Payload(_IKEv2_Packet):`
`568`	`568`	`name = "IKEv2 Payload"`
`569`	`569`	`fields_desc = [`
`570`	`570`	`ByteEnumField("next_payload", None, IKEv2PayloadTypes),`
`571`		`- FlagsField("flags", 0, 8, ["critical"]),`
	`571`	`+ FlagsField("flags", 0, 8, {0x80: "critical"}),`
`572`	`572`	`ShortField("length", None),`
`573`	`573`	`XStrLenField("load", "", length_from=lambda pkt: pkt.length - 4),`
`574`	`574`	`]`