Improve AutoArgparse & rework extensions #4806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4806 +/- ##
==========================================
- Coverage 81.02% 81.01% -0.01%
==========================================
Files 365 365
Lines 89027 89060 +33
==========================================
+ Hits 72138 72156 +18
- Misses 16889 16904 +15
🚀 New features to boost your workflow:
|
gpotter2
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the AutoArgparse decorator to support usage from scripts and adds infrastructure for bash autocompletion, while reworking the extensions loading system for Python 3.8+.
- Enhanced AutoArgparse with a
_parseonlymode for generating bash autocompletion metadata - Added bash autocompletion infrastructure with XDG-compliant directory detection and file copying utilities
- Refactored extensions loading to be more explicit and moved it to the interactive session startup
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| scapy/utils.py | Enhanced AutoArgparse to support parseonly mode and improved parameter processing for bash completion |
| scapy/main.py | Added bash autocompletion infrastructure and moved extension loading to interactive session startup |
| scapy/config.py | Refactored ExtsManager to load specific extensions explicitly instead of auto-discovering all installed packages |
Comments suppressed due to low confidence (1)
scapy/utils.py:3897
- [nitpick] The parameter name
_parseonlyuses a leading underscore which typically indicates a private/internal parameter, but this could be confusing since it's part of the public function signature. Consider renaming toparseonlyorparse_only_mode.
) -> Optional[Tuple[List[str], List[str]]]:
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4780