Fix broken locking for decomp data in model preview

RyeMutt · RyeMutt · commit 078e7606602f · 2025-10-27T04:59:16.000-04:00
Signed-off-by: Rye &lt;rye@alchemyviewer.org&gt;
diff --git a/indra/newview/llmodelpreview.cpp b/indra/newview/llmodelpreview.cpp
@@ -3649,7 +3649,7 @@ bool LLModelPreview::render()
                         LLPhysicsDecomp* decomp = gMeshRepo.mDecompThread;
                         if (decomp)
                         {
-                            LLMutexLock(decomp->mMutex);
+                            LLMutexLock decomp_lock(decomp->mMutex);
 
                             LLModel::Decomposition& physics = model->mPhysics;
 
@@ -3770,7 +3770,7 @@ bool LLModelPreview::render()
                             LLPhysicsDecomp* decomp = gMeshRepo.mDecompThread;
                             if (decomp)
                             {
-                                LLMutexLock(decomp->mMutex);
+                                LLMutexLock decomp_lock(decomp->mMutex);
 
                                 LLModel::Decomposition& physics = model->mPhysics;
 

Original file line number	Diff line number	Diff line change
`@@ -3649,7 +3649,7 @@ bool LLModelPreview::render()`
`3649`	`3649`	`LLPhysicsDecomp* decomp = gMeshRepo.mDecompThread;`
`3650`	`3650`	`if (decomp)`
`3651`	`3651`	`{`
`3652`		`- LLMutexLock(decomp->mMutex);`
	`3652`	`+ LLMutexLock decomp_lock(decomp->mMutex);`
`3653`	`3653`
`3654`	`3654`	`LLModel::Decomposition& physics = model->mPhysics;`
`3655`	`3655`
`@@ -3770,7 +3770,7 @@ bool LLModelPreview::render()`
`3770`	`3770`	`LLPhysicsDecomp* decomp = gMeshRepo.mDecompThread;`
`3771`	`3771`	`if (decomp)`
`3772`	`3772`	`{`
`3773`		`- LLMutexLock(decomp->mMutex);`
	`3773`	`+ LLMutexLock decomp_lock(decomp->mMutex);`
`3774`	`3774`
`3775`	`3775`	`LLModel::Decomposition& physics = model->mPhysics;`
`3776`	`3776`