#4839 Crash at LLPluginProcessParent::poll

akleshchev · akleshchev · commit 0d5138c1f93a · 2025-10-21T20:59:39.000+03:00
Missed lock
diff --git a/indra/llplugin/llpluginprocessparent.cpp b/indra/llplugin/llpluginprocessparent.cpp
@@ -983,6 +983,7 @@ void LLPluginProcessParent::poll(F64 timeout)
     }
 
     // Remove instances in the done state from the sInstances map.
+    LLCoros::LockType lock(*sInstancesMutex);
     mapInstances_t::iterator itClean = sInstances.begin();
     while (itClean != sInstances.end())
     {

Original file line number	Diff line number	Diff line change
`@@ -983,6 +983,7 @@ void LLPluginProcessParent::poll(F64 timeout)`
`983`	`983`	`}`
`984`	`984`
`985`	`985`	`// Remove instances in the done state from the sInstances map.`
	`986`	`+ LLCoros::LockType lock(*sInstancesMutex);`
`986`	`987`	`mapInstances_t::iterator itClean = sInstances.begin();`
`987`	`988`	`while (itClean != sInstances.end())`
`988`	`989`	`{`