Skip to content

Commit 3db8ce9

Browse files
committed
viewer#3123 Crash at LLVOTree::updateSpatialExtents
1 parent 6c6b388 commit 3db8ce9

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

indra/newview/lltexturefetch.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -537,7 +537,6 @@ class LLTextureFetchWorker : public LLWorkerClass, public LLCore::HttpHandler
537537
F32 mImagePriority; // should map to max virtual size
538538
F32 mRequestedPriority;
539539
S32 mDesiredDiscard;
540-
S32 mSimRequestedDiscard;
541540
S32 mRequestedDiscard;
542541
S32 mLoadedDiscard;
543542
S32 mDecodedDiscard;
@@ -870,7 +869,6 @@ LLTextureFetchWorker::LLTextureFetchWorker(LLTextureFetch* fetcher,
870869
mImagePriority(priority),
871870
mRequestedPriority(0.f),
872871
mDesiredDiscard(-1),
873-
mSimRequestedDiscard(-1),
874872
mRequestedDiscard(-1),
875873
mLoadedDiscard(-1),
876874
mDecodedDiscard(-1),

indra/newview/llvotree.cpp

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1167,9 +1167,15 @@ void LLVOTree::updateSpatialExtents(LLVector4a& newMin, LLVector4a& newMax)
11671167
pos.load3(center.mV);
11681168
mDrawable->setPositionGroup(pos);
11691169

1170-
LLFace* facep = mDrawable->getFace(0);
1171-
facep->mExtents[0] = newMin;
1172-
facep->mExtents[1] = newMax;
1170+
if (mDrawable->getNumFaces() > 0)
1171+
{
1172+
LLFace* facep = mDrawable->getFace(0);
1173+
if (facep)
1174+
{
1175+
facep->mExtents[0] = newMin;
1176+
facep->mExtents[1] = newMax;
1177+
}
1178+
}
11731179
}
11741180

11751181
bool LLVOTree::lineSegmentIntersect(const LLVector4a& start, const LLVector4a& end, S32 face, bool pick_transparent, bool pick_rigged, bool pick_unselectable, S32 *face_hitp,

0 commit comments

Comments
 (0)