Skip to content

Commit cfbcdd7

Browse files
committed
Fix: Remove potentially redundant RenderAutoHideSurfaceAreaLimit setting registration
This commit removes a seemingly duplicated `connectRefreshCachedSettingsSafe` call in `LLPipeline::init()` for the `RenderAutoHideSurfaceAreaLimit` setting. A duplicated registration for this setting was identified during a review of `LLPipeline::init()`. Double registration can lead to unexpected behavior, including potential CPU overhead. The duplication *may* have been introduced with commit 440c7b2 (Added CollectFontVertexBuffers feature), though this requires further confirmation. Testing Performed: After removing the duplicate registration, the `RenderAutoHideSurfaceAreaLimit` functionality was validated by ensuring the following behavior (consistent with the existing code): * A value of 0 (zero) causes all objects to appear regardless of size. * Values slightly above zero result in only small objects appearing, with all others hidden. * Increasing the value causes objects of increasing size to appear, while smaller objects remain visible. This change merits careful review to ensure it has no unintended side effects, and to confirm the accuracy of these observations from other developers.
1 parent be2e7e9 commit cfbcdd7

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

indra/newview/pipeline.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,6 @@ void LLPipeline::init()
599599
connectRefreshCachedSettingsSafe("RenderMirrors");
600600
connectRefreshCachedSettingsSafe("RenderHeroProbeUpdateRate");
601601
connectRefreshCachedSettingsSafe("RenderHeroProbeConservativeUpdateMultiplier");
602-
connectRefreshCachedSettingsSafe("RenderAutoHideSurfaceAreaLimit");
603602

604603
LLPointer<LLControlVariable> cntrl_ptr = gSavedSettings.getControl("CollectFontVertexBuffers");
605604
if (cntrl_ptr.notNull())

0 commit comments

Comments
 (0)