When using unique_ptr for PBRPickerAgentListener and PBRPickerObjectListener, default_delete must be defined.

Author: AiraYumi

indra/newview/llpanelface.cpp

@@ -1838,6 +1838,7 @@ class PBRPickerAgentListener : public LLInventoryObserver
         mChangePending = false;
     }
 };
+void std::default_delete<PBRPickerAgentListener>::operator()(PBRPickerAgentListener * ptr) const noexcept { delete ptr; }
 
 // One-off listener that updates the build floater UI when the prim inventory updates
 class PBRPickerObjectListener : public LLVOInventoryListener
@@ -1877,6 +1878,7 @@ class PBRPickerObjectListener : public LLVOInventoryListener
         mChangePending = false;
     }
 };
+void std::default_delete<PBRPickerObjectListener>::operator()(PBRPickerObjectListener * ptr) const noexcept { delete ptr; }
 
 void LLPanelFace::updateUIGLTF(LLViewerObject* objectp, bool& has_pbr_material, bool& has_faces_without_pbr, bool force_set_values)
 {

indra/newview/llpanelface.h

@@ -57,6 +57,18 @@ class LLRadioGroup;
 class PBRPickerAgentListener;
 class PBRPickerObjectListener;
 
+// This is specializations are needed to support std::unique_ptr<T> where T is an incomplete type
+namespace std {
+    template<> struct default_delete<PBRPickerAgentListener> {
+        constexpr default_delete() noexcept = default;
+        void operator()(PBRPickerAgentListener* ptr) const noexcept;
+    };
+    template<> struct default_delete<PBRPickerObjectListener> {
+        constexpr default_delete() noexcept = default;
+        void operator()(PBRPickerObjectListener* ptr) const noexcept;
+    };
+}
+
 // Represents an edit for use in replicating the op across one or more materials in the selection set.
 //
 // The apply function optionally performs the edit which it implements