[#5210] Improve detection of marketplace urls for the preloaded marketplace floater#5459
Merged
akleshchev merged 1 commit intosecondlife:developfrom Mar 20, 2026
Conversation
akleshchev
approved these changes
Mar 20, 2026
Contributor
|
Thank you! The rest of the work appears to be in 2026.2, not in develop so I'm, not sure where this is going to land. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #5210
Follow up to Dan-Lindens test on Mac: #5210 (comment)
I got a few people to test the original change on their Macs and everything was behaving as expected.
So I suspect the reason why a marketplace url did not open with the preloaded-marketplace floater when Dan-Linden tested, was one of a few reason-
As to why they weren't already logged in to the marketplace, that is out of scope and not a result of the marketplace changes I've made, and would be a result of the cookies not getting loaded or were invalid for some reason.
This PR simply just trims off the https:// or http:// from urls and removes any trailing /'s. That way when it compares against MarketplaceURL which also gets trimmed, it can more accurately determine if it was a marketplace url that is trying to be opened so it can use the preloaded marketplace floater.