Skip to content

[#5210] Improve detection of marketplace urls for the preloaded marketplace floater#5459

Merged
akleshchev merged 1 commit intosecondlife:developfrom
Hecklezz:improvement/marketplace_url_detection
Mar 20, 2026
Merged

[#5210] Improve detection of marketplace urls for the preloaded marketplace floater#5459
akleshchev merged 1 commit intosecondlife:developfrom
Hecklezz:improvement/marketplace_url_detection

Conversation

@Hecklezz
Copy link
Contributor

Issue: #5210
Follow up to Dan-Lindens test on Mac: #5210 (comment)

I got a few people to test the original change on their Macs and everything was behaving as expected.
So I suspect the reason why a marketplace url did not open with the preloaded-marketplace floater when Dan-Linden tested, was one of a few reason-

  1. The url started with http:// and not https:// (This PR addresses this)
  2. The url was simply https://marketplace.secondlife.com without the trailing / (This PR addresses this)
  3. Their MarketplaceURL setting is modified (This PR does not address this and they need to default it)

As to why they weren't already logged in to the marketplace, that is out of scope and not a result of the marketplace changes I've made, and would be a result of the cookies not getting loaded or were invalid for some reason.

This PR simply just trims off the https:// or http:// from urls and removes any trailing /'s. That way when it compares against MarketplaceURL which also gets trimmed, it can more accurately determine if it was a marketplace url that is trying to be opened so it can use the preloaded marketplace floater.

@akleshchev
Copy link
Contributor

akleshchev commented Mar 20, 2026

Thank you!

The rest of the work appears to be in 2026.2, not in develop so I'm, not sure where this is going to land.

@akleshchev akleshchev merged commit e9b39bf into secondlife:develop Mar 20, 2026
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When a Second Life Marketplace url is clicked, load it using the preloaded marketplace floater

2 participants