Skip to content

Add sldecode and slencode Lua JSON helpers #5114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marchcat merged 1 commit into from
Dec 9, 2025
Merged

Add sldecode and slencode Lua JSON helpers #5114

marchcat merged 1 commit into from
Dec 9, 2025
+78 −0

Conversation

@mikelittman
Copy link

@mikelittman mikelittman commented Dec 6, 2025 •
edited
Loading

Description

Adds newly deployed slua functions slencode and sldecode.
This PR matches changes made here: secondlife/sl-vscode-plugin#40

Issue Link: n/a

Checklist

Please ensure the following before requesting review:

  • I have provided a clear title and detailed description for this pull request.
  • If useful, I have included media such as screenshots and video to show off my changes.
  • The PR is linked to a relevant issue with sufficient context.
  • I have tested the changes locally and verified they work as intended.
  • All new and existing tests pass.
  • Code follows the project's style guidelines.
  • Documentation has been updated if needed.
  • Any dependent changes have been merged and published in downstream modules
  • I have reviewed the contributing guidelines.

Additional Notes

@github-actions
Copy link

github-actions bot commented Dec 6, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@mikelittman
Copy link
Author

mikelittman commented Dec 6, 2025

I have read the CLA Document and I hereby sign the CLA

recheck

@mikelittman mikelittman marked this pull request as ready for review December 6, 2025 01:52
@mikelittman
Copy link
Author

mikelittman commented Dec 6, 2025

recheck

@akleshchev
Copy link
Contributor

akleshchev commented Dec 8, 2025

I think it got confused by both a recheck and the signing being in the same comment. Doesn't looke like there are errors in the new run, just the 'Committers of Pull Request number 5114 have to sign the CLA'.

@marchcat
Copy link
Contributor

marchcat commented Dec 8, 2025

@mikelittman, thank you for the contribution!

I don't see any errors except that weird CLA bot behavior. Please try to post that "I have read ..." message again, and if it fails - just ping me and I'll merge it manually, since it's a project viewer and you have already signed the agreement anyway.

@mikelittman
Copy link
Author

mikelittman commented Dec 9, 2025

I have read the CLA Document and I hereby sign the CLA

@marchcat marchcat merged commit 21d62c5 into secondlife:project/lua_editor Dec 9, 2025
18 of 21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marchcat marchcat marchcat approved these changes

@Rider-Linden Rider-Linden Awaiting requested review from Rider-Linden

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikelittman @akleshchev @marchcat